-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Improve documentation with regards to running tests locally #613
Docs: Improve documentation with regards to running tests locally #613
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea to separate back-end and front-end tests is good, but:
- I think running tests both on push and pull_request is unnecessary. In our workflow, pushing is usually followed by pull request, so the same tests will be running twice.
- Our front-end tests do not need the back-end tests. They can be run independently.
- We already have
test-back
andtest-front
scripts set up, perhaps documentation should reflect that. - @BeritJanssen can you comment on
docker exec
vsdocker run
?
Good points! I've updated the workflow accordingly. With regards to point 1.: I've edited it so that the workflow will run for a PR and for every push to
Fair point as well. I was looking at the commands in those scripts and realized Windows doesn't have |
As the name of the container is not the same across all users, I prefer As with #620, I'd also request that documentation on how to run the tests be moved to the wiki, so as not to clutter the README. |
Ah yes, with the |
tests in README.md
GitHub Actions workflow
request events
0827aa9
to
dc56187
Compare
Ah, I never realized you could set the container name. So no, no conscious decision. But what would happen if somebody spins up multiple containers? You would then still get server_1, server_2 and so on? I think that last bit is what Docker attaches nonetheless, and I noticed that it can differ whether the index is slapped on with hyphen or underscore. Perhaps there's a setting for that, too. |
This PR aims to add the following:
push
andpull_request
events.