-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/break actions #562
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SongSync with external files isn't working. In the SongSync wrapper the play_method isn't set, so it defaults to buffer. This was previously set in the config of SongSync, because playAudio was called from there.
In hooked.py this is set as a constant at the top of the file, so maybe we can add this as an argument for song_sync from there, so it can be set from the rules file.
Ah, good catch! In the meantime, I've started working on #561 - in there, I introduce logic that sets the play method based on the path / duration of the file, so hopefully these kind of oversights can be also prevented in the future. |
c7572a5
to
0b2211c
Compare
0b2211c
to
6ad1253
Compare
Styling bug: |
Can you share a screen capture of this problem? I think this only occurs after passing the training phase, right? |
I fixed the spacing of the buttons (the main difference with the current develop branch). Will make a separate issue of the jumping buttons - this is unrelated. It already happens in the current develop branch. |
Close #251 . Close #599 . Instead of introducing a new
Sequential
action, or adding information to thenext_round
array, I found a much less invasive way of accomplishing views with some either/or logic, such as Plink or SongSync: in the config of aTrial
, pass along conditions under which the currentnext_round
array is not handled to the end, but new round data requested from the server instead.To do: