Docs: Improve type annotations and documentation for utility functions in experiment actions #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeritJanssen
reviewed
Jan 6, 2025
BeritJanssen
reviewed
Jan 6, 2025
BeritJanssen
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Thanks! I still corrected the definition of continuation_correctness. I guess that variable doesn't have the clearest name... On another branch, I actually moved to clean up the utils function so very rules specific content, such as the randomize_playhead and all the stuff relating to turnpoints, would be moved to those rules files instead. So hopefully that makes defining the utility functions easier, as they are far from generic.
…s in experiment actions
Co-authored-by: Berit <[email protected]>
Co-authored-by: Berit <[email protected]>
drikusroor
force-pushed
the
docs/utils-actions
branch
from
d36bc70 to
b24e232
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance type annotations and documentation for clarity and usability of utility functions related to experiment actions.
Related to #1428