Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Improve documentation and typing for Form and Question classes #1446

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Docs: Improve documentation and typing for Form and Question classes #1446

merged 2 commits into from
Jan 8, 2025

Conversation

drikusroor
Copy link
Contributor

@drikusroor drikusroor commented Dec 24, 2024 •
edited
Loading

Enhance the documentation and typing for the Form action class and all Question classes.

Related to #1428

@drikusroor drikusroor self-assigned this Dec 24, 2024
@drikusroor drikusroor requested a review from Evert-R December 24, 2024 10:46
@drikusroor drikusroor added the documentation Improvements or additions to documentation label Dec 24, 2024
@drikusroor drikusroor mentioned this pull request Dec 24, 2024
Open
26 tasks
BeritJanssen
BeritJanssen approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@BeritJanssen BeritJanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Only wonder whether we can make the relationships between different question types clearer by more specific inheritance. No precondition for merging though.

backend/experiment/actions/form.py Outdated Show resolved Hide resolved
backend/experiment/actions/form.py Show resolved Hide resolved
backend/experiment/actions/form.py Show resolved Hide resolved
@drikusroor drikusroor mentioned this pull request Jan 8, 2025
Open
@drikusroor drikusroor merged commit d57f7ee into develop Jan 8, 2025
7 checks passed
@drikusroor drikusroor deleted the docs/form branch January 8, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeritJanssen BeritJanssen BeritJanssen approved these changes

@Evert-R Evert-R Awaiting requested review from Evert-R

Assignees

@drikusroor drikusroor

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drikusroor @BeritJanssen