Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v3.6.0 #63

Closed
wants to merge 102 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
102 commits
Select commit Hold shift + click to select a range
d24c4f6
chore: ASC-00000 - css module typescript config (#233)
bonanaaaaaa Apr 9, 2024
54c354e
fix: ASC-21254 - align api signature for draft page (#210)
chaiwattsw Apr 9, 2024
b823c8a
fix: ASC-21249 - align story tab component props (#203)
chaiwattsw Apr 9, 2024
f3fdbe0
fix: ASC-21260 - align comment tray component props (#202)
chaiwattsw Apr 9, 2024
3844fcf
fix: ASC-21404 - AmityViewStoryPage signature alignment (#209)
chaiwattsw Apr 9, 2024
d383e4c
feat: add to support 6 users for storybook (#238)
ptchayap Apr 10, 2024
f9e2f4d
feat: ASC-00000 - use more env from secrets (#239)
ptchayap Apr 10, 2024
a10ce17
feat: ASC-00000 - add more storybook user (#240)
ptchayap Apr 10, 2024
1451795
fix: permission (#244)
chaiwattsw Apr 10, 2024
42fd40b
fix: ASC-21393 - refactor customization 4.0 (#211)
chaiwattsw Apr 11, 2024
be5c85b
feat(chat): ASC-0000 - Chat V4 big chunk 1 (#214)
frankent Apr 12, 2024
f826ff4
feat(chat): ASC-0000 - export compose bar (#258)
frankent Apr 12, 2024
b26358e
feat: export v4 provider (#259)
ptchayap Apr 12, 2024
7f1b545
Release/v4.0.0 beta.1 (#262)
ptchayap Apr 12, 2024
40bb79a
fix: ASC-00000 - export type (#263)
ptchayap Apr 12, 2024
f1f1106
fix: ASC-00000 - fix provider v4 props (#261)
chaiwattsw Apr 12, 2024
f1ae3bd
Release/v4.0.0 beta.2 (#265)
ptchayap Apr 17, 2024
4f55e38
feat: ASC-20277 - flag unflag message (#267)
ptchayap Apr 19, 2024
deb28b1
fix: ASC-00000 - remove sheet loading state (#271)
ptchayap Apr 22, 2024
4621765
fix: ASC-21913 - type and optional field on config (#268)
ptchayap Apr 22, 2024
ff4f4d3
fix: add error state on delete message (#269)
ptchayap Apr 22, 2024
e47b597
fix: ASC-21767 - mention border when got mention (#272)
ptchayap Apr 22, 2024
c46baa7
feat: ASC-21691 - add hyperlink style to primary color (#270)
ptchayap Apr 22, 2024
ac7c5f6
fix(social): asc-00000 use internal path (#266)
frankent Apr 22, 2024
278c60a
feat: ASC-17980 - global feed story targets tab and story target circ…
chaiwattsw Apr 23, 2024
7799451
feat(chat): ASC-00000 - Muted + Banned channel (#276)
frankent Apr 23, 2024
60cdada
feat(chat): ASC-00000 - fix composebar styling + limit 200 character …
frankent Apr 23, 2024
af4f290
fix: ASC-21913 - config type (#278)
ptchayap Apr 23, 2024
f7c1934
fix: add blocked word + not allowed link (#280)
frankent Apr 23, 2024
0698b8e
fix: icon (#281)
chaiwattsw Apr 23, 2024
fcbaf43
fix: using v3 and v4 provider separately for each stories (#284)
bonanaaaaaa Apr 24, 2024
f399aa4
fix: ASC-00000 - confirm context (#285)
bonanaaaaaa Apr 24, 2024
20878a7
fix: ASC-00000 - notification context (#286)
bonanaaaaaa Apr 24, 2024
0197c27
fix: ASC-00000 - add login step on UiKitProvider (#287)
bonanaaaaaa Apr 24, 2024
0942cb0
fix: message remain on compose bar after sending success (#289)
ptchayap Apr 24, 2024
ab87cd0
fix: user muted state (#293)
ptchayap Apr 25, 2024
a87b1cf
fix: ASC-22026 - moderator cannot send message on muted channel (#294)
ptchayap Apr 25, 2024
b47ba77
fix: ASC-219999 - incorrect comment count color (#283)
chaiwattsw Apr 25, 2024
1bfad59
fix: ASC-21979 - can't click header on video preview (#282)
chaiwattsw Apr 25, 2024
e141fb8
fix: use v4 (#295)
chaiwattsw Apr 25, 2024
5b229e2
fix: ASC-20502 - shouldAllowCreation condition (#296)
chaiwattsw Apr 25, 2024
4955abc
fix: ASC-20883 - remove latestComments prop (#290)
bonanaaaaaa Apr 25, 2024
313ffdf
fix: add v3 provider (#298)
bonanaaaaaa Apr 25, 2024
0052c57
fix: ASC-21980 - hyper link background color (#299)
chaiwattsw Apr 25, 2024
ae84a93
feat: ASC-21665 - darkmode config (#279)
ptchayap Apr 25, 2024
108a81c
fix: ASC-21980 - fix remove link button style (#300)
chaiwattsw Apr 25, 2024
fc7745e
fix: character limit (#302)
ptchayap Apr 25, 2024
d188c37
fix: change permission to check if user is a moderator (#304)
ptchayap Apr 26, 2024
d79d39a
fix: ASC-22060 - remove onBack() on draft page (#303)
chaiwattsw Apr 26, 2024
663520d
fix: ASC-21980 - hyperlink style (#301)
chaiwattsw Apr 26, 2024
8c0ad0c
fix: ASC-22063 - fix story global feed pagination (#305)
chaiwattsw Apr 26, 2024
7ac3965
fix: official condition (#306)
chaiwattsw Apr 26, 2024
04e1a61
fix: ASC-19646 - notification error when failed create story (#307)
chaiwattsw Apr 26, 2024
72b7abf
fix: ASC-22060 - navigate to community when create story (#308)
chaiwattsw Apr 26, 2024
ebf39f0
fix: ASC-21985 - navigate story target for global feed story (#309)
chaiwattsw Apr 26, 2024
6120a05
fix: ASC-21970 - story uploading state (#297)
chaiwattsw Apr 26, 2024
e1e17e9
fix: notification style (#311)
chaiwattsw Apr 26, 2024
2b05e24
fix: add onAllStoriesEnd (#312)
chaiwattsw Apr 26, 2024
bfe560c
Release/v4.0.0 beta.3 (#314)
ptchayap Apr 26, 2024
acd2075
chore(sdk): ASC-00000 - custom build ci (#316)
bonanaaaaaa Apr 29, 2024
61368cc
feat: only creator or story permission can see impression (#319)
chaiwattsw Apr 30, 2024
3dc7893
feat: ASC-22084 - StoryPreview component for Console (#317)
chaiwattsw Apr 30, 2024
3919fe7
update readme (#323)
frankent May 2, 2024
baebc18
feat: ASC-20558 - swipe down gesture to close story (#321)
chaiwattsw May 7, 2024
240f0e5
fix: ASC-22263 - hyperlink background (#326)
chaiwattsw May 8, 2024
e3e1dcd
fix: ASC-22263 - hyperlink doesn't show in view story page (#328)
chaiwattsw May 9, 2024
3c6cbf4
fix: ASC-22264 - reply comment margin (#329)
chaiwattsw May 10, 2024
bbcd949
fix: ASC-21792 - comment list infinite scroll (#330)
chaiwattsw May 13, 2024
3528ce4
Release/v4.0.0 beta.4 (#334)
bonanaaaaaa May 13, 2024
1e41eef
fix: to support un config value (#340)
ptchayap May 15, 2024
2662160
fix: hyperlink long text (#335)
chaiwattsw May 20, 2024
ccdbbdd
fix: hyperlink custom text input max length (#336)
chaiwattsw May 20, 2024
3ebfc1a
fix: ASC-220001 - share story button (#337)
chaiwattsw May 20, 2024
067ff98
fix: ASC-21590 - hyperlink ui (#347)
chaiwattsw May 20, 2024
83a1d34
fix: story commu condition (#346)
chaiwattsw May 20, 2024
fe8aab8
feat: ASC-22133 - custom reaction provider (#325)
ptchayap May 20, 2024
eca154a
fix: ASC-22623 - story video (#349)
chaiwattsw May 24, 2024
596d158
feat(reaction): update condition (#350)
frankent May 24, 2024
2d95eb1
fix(reaction): ASC-22611 - update missing ui and action to remove rea…
frankent May 24, 2024
1799fe5
fix: create story condition (#352)
chaiwattsw May 24, 2024
7d6e687
fix: ASC-222740 - create story condition for global-admin role (#354)
chaiwattsw May 27, 2024
0c95669
fix(reaction): ASC-22622 - fix reaction UI bugs (#355)
frankent May 27, 2024
c138b57
fix: ASC-22740 - create story permission condition to create story (#…
chaiwattsw May 27, 2024
be48905
feat(SDK): test build
frankent May 28, 2024
cc22a38
feat(SDK): upgrade ts-sdk version
frankent May 28, 2024
3a74cb6
fix: ASC-21529 - view story wrapper css (#359)
chaiwattsw May 31, 2024
00f978f
fix: ASC-20521 - story delete condition (#360)
chaiwattsw May 31, 2024
22062fa
fix: ASC-20505 - condition for non member (#361)
chaiwattsw Jun 4, 2024
478f3a6
fix: hook (#362)
chaiwattsw Jun 4, 2024
6efd829
fix: ASC-22947 - hyperlink config bottom sheet condition (#367)
chaiwattsw Jun 5, 2024
e887e78
fix: ASC-22949 - video story bug when delete (#366)
chaiwattsw Jun 5, 2024
896cffb
fix: close bottom sheet condition (#365)
chaiwattsw Jun 5, 2024
d85467c
fix: ASC-20502 - comment condition (#363)
chaiwattsw Jun 5, 2024
27c1aab
fix: ASC-22484 - hyperlink config css (#345)
chaiwattsw Jun 5, 2024
52f83a3
fix: ASC-20532 - deleted comment block (#364)
chaiwattsw Jun 5, 2024
14171c3
fix: category card responsive styles (#372)
chaiwattsw Jun 6, 2024
2349f87
fix: ASC-22947 - story can't add hyperlink (#373)
chaiwattsw Jun 6, 2024
8e3f30c
fix: ASC-00000 - bring back v3 code (#358)
bonanaaaaaa Jun 6, 2024
59a97e6
fix: video should pause when click item in action menu (#375)
chaiwattsw Jun 7, 2024
7a67b43
fix: hyperlink text color (#376)
chaiwattsw Jun 7, 2024
c80ef32
fix: ASC-21507 - reset form when confirm remove hyperlink (#368)
chaiwattsw Jun 7, 2024
ddc4cde
Merge remote-tracking branch 'upstream/develop' into release/v6.26.0
chaiwattsw Jun 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/i18n/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -359,12 +359,12 @@
"storyCreation.hyperlink.form.linkTextLabel": "Customize link text",
"storyCreation.hyperlink.form.linkTextPlaceholder": "Name your link",
"storyCreation.hyperlink.form.linkTextDescription": "This text will show on the link instead of URL.",
"storyCreation.hyperlink.validation.invalidUrl": "Please enter a valid URL.",
"storyCreation.hyperlink.form.removeButton": "Remove link",
"storyCreation.hyperlink.removeConfirm.title": "Remove link",
"storyCreation.hyperlink.removeConfirm.content": "This link will be removed from story.",
"storyCreation.hyperlink.removeConfirm.cancel": "Cancel",
"storyCreation.hyperlink.removeConfirm.confirm": "Remove",
"storyCreation.hyperlink.validation.error.invalidUrl": "Please enter a valid URL.",
"storyCreation.hyperlink.validation.error.whitelisted": "Please enter a whitelisted URL.",
"storyCreation.hyperlink.validation.error.blocked": "Your text contains a blocklisted word.",

Expand All @@ -381,10 +381,15 @@
"storyViewer.commentSheet.disabled": "Comments are disabled for this story",
"storyViewer.commentSheet.replyingTo": "Replying to",
"storyViewer.toast.like.disabled": "Join community to interact with all stories",
"storyViewer.toast.comment.reported": "Comment reported",
"storyViewer.toast.comment.unreported": "Comment unreported",

"storyViewer.commentComposeBar.submit": "Post",

"storyDraft.button.shareStory": "Share story",
"storyDraft.notification.hyperlink.error": "Can’t add more than one link to your story.",

"storyTab.title": "Story",

"storyTab.title": "Story",

Expand Down
17 changes: 7 additions & 10 deletions src/social/components/CommentList/index.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
import React, { memo } from 'react';
import { useIntl } from 'react-intl';

import Comment from '~/social/components/Comment';
import { NoCommentsContainer, TabIcon, TabIconContainer } from './styles';

import { TabIcon, TabIconContainer } from './styles';
import LoadMoreWrapper from '../LoadMoreWrapper';
import usePostSubscription from '~/social/hooks/usePostSubscription';
import { SubscriptionLevels } from '@amityco/ts-sdk';
Expand All @@ -11,6 +13,7 @@ interface CommentListProps {
parentId?: string;
referenceId?: string;
referenceType: Amity.CommentReferenceType;
// filterByParentId?: boolean;
readonly?: boolean;
isExpanded?: boolean;
limit?: number;
Expand All @@ -21,6 +24,8 @@ const CommentList = ({
referenceId,
referenceType,
limit = 5,
// TODO: breaking change
// filterByParentId = false,
readonly = false,
isExpanded = true,
}: CommentListProps) => {
Expand All @@ -41,7 +46,7 @@ const CommentList = ({
});

const loadMoreText = isReplyComment
? formatMessage({ id: 'collapsible.viewMoreReplies' })
? formatMessage({ id: 'collapsible.viewMoreReplies' }, { count: comments.length })
: formatMessage({ id: 'collapsible.viewMoreComments' });

const prependIcon = isReplyComment ? (
Expand All @@ -50,14 +55,6 @@ const CommentList = ({
</TabIconContainer>
) : null;

if (comments.length === 0 && referenceType === 'story' && !isReplyComment) {
return (
<NoCommentsContainer>
{formatMessage({ id: 'storyViewer.commentSheet.empty' })}
</NoCommentsContainer>
);
}

if (comments.length === 0) return null;

return (
Expand Down
10 changes: 0 additions & 10 deletions src/social/components/CommentList/styles.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,3 @@ export const TabIconContainer = styled.div`
display: flex;
margin-right: 8px;
`;

export const NoCommentsContainer = styled.div`
${({ theme }) => theme.typography.body};
color: ${({ theme }) => theme.palette.base.shade2};
display: flex;
flex-direction: column;
align-items: center;
justify-content: center;
height: 100%;
`;
4 changes: 2 additions & 2 deletions src/social/components/EngagementBar/UIEngagementBar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ const UIEngagementBar = ({
<CommentIcon /> <FormattedMessage id="comment" />
</SecondaryButton>
</InteractionBar>
{latestComments.length > 0 ? (
{latestComments?.length > 0 ? (
<CommentList referenceId={postId} referenceType={'post'} limit={COMMENTS_PER_PAGE} />
) : null}

Expand All @@ -91,7 +91,7 @@ const UIEngagementBar = ({
<NoInteractionMessage>
<FormattedMessage id="community.cannotInteract" />
</NoInteractionMessage>
{latestComments.length > 0 ? (
{latestComments?.length > 0 ? (
<CommentList
referenceId={postId}
referenceType={'post'}
Expand Down
1 change: 1 addition & 0 deletions src/social/components/Feed/index.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import React, { memo, useCallback } from 'react';
import DefaultPostRenderer from '~/social/components/post/Post/DefaultPostRenderer';

import useCommunitiesList from '~/social/hooks/useCommunitiesList';
import PostCreator from '~/social/components/post/Creator';
import Post from '~/social/components/post/Post';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@ import styled from 'styled-components';
import EmptyState from '~/core/components/EmptyState';

export const Grid = styled.div`
display: flex;
flex-direction: row;
flex-wrap: wrap;
gap: 16px;
display: grid;
grid-template-columns: repeat(auto-fit, minmax(250px, 1fr));
gap: 1rem;
`;

export const ListEmptyState = styled(EmptyState)`
Expand Down
31 changes: 16 additions & 15 deletions src/social/components/post/Post/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@ import React, { memo } from 'react';
import usePost from '~/social/hooks/usePost';
import usePoll from '~/social/hooks/usePoll';
import DefaultPostRenderer from './DefaultPostRenderer';

import useSDK from '~/core/hooks/useSDK';
import useUser from '~/core/hooks/useUser';
import { PollRepository, PostRepository, SubscriptionLevels } from '@amityco/ts-sdk';

import usePostByIds from '~/social/hooks/usePostByIds';
import { useCustomComponent } from '~/core/providers/CustomComponentsProvider';
import useImage from '~/core/hooks/useImage';
import usePostFlaggedByMe from '~/social/hooks/usePostFlaggedByMe';
Expand All @@ -23,11 +24,13 @@ interface PostProps {

const Post = ({ postId, className, hidePostTarget, readonly, onDeleted }: PostProps) => {
const post = usePost(postId);
const avatarFileUrl = useImage({ fileId: post?.creator?.avatarFileId, imageSize: 'small' });

const { isFlaggedByMe, flagPost, unflagPost } = usePostFlaggedByMe(post);

const postedUser = useUser(post?.postedUserId);
const avatarFileUrl = useImage({ fileId: postedUser?.avatarFileId, imageSize: 'small' });
const childrenPosts = usePostByIds(post?.children);
const { userRoles } = useSDK();
const { isFlaggedByMe, toggleFlagPost } = usePostFlaggedByMe(post);
const postRenderFn = usePostRenderer(post?.dataType);
const { currentUserId } = useSDK();

usePostSubscription({
postId,
Expand All @@ -40,9 +43,7 @@ const Post = ({ postId, className, hidePostTarget, readonly, onDeleted }: PostPr
shouldSubscribe: () => !!post,
});

const pollPost = (post?.latestComments || []).find(
(childPost: Amity.Post) => childPost.dataType === 'poll',
);
const pollPost = (childrenPosts || []).find((childPost) => childPost.dataType === 'poll');

const poll = usePoll((pollPost?.data as Amity.ContentDataPoll)?.pollId);
const isPollClosed = poll?.status === 'closed';
Expand Down Expand Up @@ -74,21 +75,21 @@ const Post = ({ postId, className, hidePostTarget, readonly, onDeleted }: PostPr
return (
<>
{postRenderFn({
childrenPosts: post?.latestComments || [],
childrenPosts: childrenPosts || [],
handleClosePoll,
isPollClosed,
avatarFileUrl,
user: post?.creator,
user: postedUser,
poll,
className,
currentUserId: post?.postedUserId || undefined,
currentUserId: currentUserId || undefined,
hidePostTarget,
post,
userRoles: post?.creator?.roles || [],
userRoles,
readonly,
isFlaggedByMe,
handleReportPost: flagPost,
handleUnreportPost: unflagPost,
handleReportPost: toggleFlagPost,
handleUnreportPost: toggleFlagPost,
handleApprovePost,
handleDeclinePost,
handleDeletePost,
Expand Down
4 changes: 1 addition & 3 deletions src/social/hooks/collections/useCommentsCollection.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ type useCommentsParams = {
referenceId?: string | null;
referenceType: Amity.CommentReferenceType;
limit?: number;
shouldCall?: () => boolean;
// breaking changes
// first?: number;
// last?: number;
Expand All @@ -18,7 +17,6 @@ export default function useCommentsCollection({
referenceId,
referenceType,
limit = 10,
shouldCall = () => true,
}: useCommentsParams) {
const { items, ...rest } = useLiveCollection({
fetcher: CommentRepository.getComments,
Expand All @@ -28,7 +26,7 @@ export default function useCommentsCollection({
referenceType,
limit,
},
shouldCall: () => shouldCall() && !!referenceId && !!referenceType,
shouldCall: () => !!referenceId && !!referenceType,
});

return {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,8 @@ export const AmityLiveChatMessageComposeBar = ({
multiline
disabled={disabled}
placeholder={
componentConfig?.placeholder_text ||
(typeof componentConfig?.placeholder_text === 'string' &&
componentConfig?.placeholder_text) ||
formatMessage({
id: 'livechat.composebar.placeholder',
})
Expand Down
7 changes: 5 additions & 2 deletions src/v4/chat/components/MessageQuickReaction/index.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React, { useCallback } from 'react';
import { useCustomization } from '~/v4/core/providers/CustomizationProvider';
import { useCustomReaction } from '~/v4/core/providers/CustomReactionProvider';
import { AmityReactionType, useCustomReaction } from '~/v4/core/providers/CustomReactionProvider';
import { QuickReactionIcon } from '~/v4/icons/QuickReactionIcon';
import { selectMessageReaction } from '~/v4/utils/selectMessageReaction';
import styles from './styles.module.css';
Expand Down Expand Up @@ -30,7 +30,10 @@ export const MessageQuickReaction = ({
elementConfig.reaction &&
reactionConfig.find((config) => config.name === elementConfig.reaction)
) {
selectMessageReaction({ reactionName: elementConfig.reaction, message });
selectMessageReaction({
reactionName: elementConfig.reaction as AmityReactionType['name'],
message,
});
}

onSelectReaction && onSelectReaction();
Expand Down
29 changes: 12 additions & 17 deletions src/v4/core/components/BottomSheet/BottomSheet.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -4,29 +4,24 @@ Note that you might need to use !important for style overrides since the inner s
which have higher specificity.
*/

.react-modal-sheet-container {
color: var(--asc-color-base-default);
}

.react-modal-sheet-backdrop {
background-color: var(--asc-color-base-inverse, rgba(0, 0, 0, 0.5));
.bottomSheet__container {
background-color: var(--asc-color-base-background);
}

.react-modal-sheet-header {
.bottomSheet__header {
padding: 1rem;
display: flex;
padding-bottom: 1rem;
justify-content: center;
align-items: center;
gap: 0.5rem;
align-self: stretch;
background-color: var(--asc-color-base-background);
color: var(--asc-color-base-default);
border-bottom: 1px solid var(--asc-color-base-shade4);
}

.react-modal-sheet-content {
display: flex;
.bottomSheet__drag-indicator {
}

.bottomSheet__content {
background-color: var(--asc-color-base-background);
padding: 1rem;
color: var(--asc-color-base-default);
}

.bottomSheet__backdrop {
background-color: rgba(0, 0, 0, 0.5);
}
27 changes: 12 additions & 15 deletions src/v4/core/components/BottomSheet/BottomSheet.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,32 +14,29 @@ interface BottomSheetProps {
headerTitle?: string;
cancelText?: string;
okText?: string;
className?: string;
}

export const BottomSheet = ({ children, headerTitle, ...props }: BottomSheetProps) => {
return (
<Sheet {...props}>
<Sheet.Container
className={styles['react-modal-sheet-container']}
style={{
backgroundColor: 'var(--asc-color-base-background)',
}}
>
<Sheet.Container className={styles.bottomSheet__container}>
<Sheet.Header
style={{
borderTopLeftRadius: '1.25rem',
borderTopRightRadius: '1.25rem',
backgroundColor: 'var(--asc-color-base-background)',
}}
/>
{headerTitle && (
<Sheet.Header className={styles['react-modal-sheet-header']}>
<Typography.Title>{headerTitle}</Typography.Title>
</Sheet.Header>
)}
<Sheet.Content className={styles['react-modal-sheet-content']}>{children}</Sheet.Content>
>
<Sheet.Header />
{headerTitle && (
<Sheet.Header className={styles.bottomSheet__header}>
<Typography.Title>{headerTitle}</Typography.Title>
</Sheet.Header>
)}
</Sheet.Header>
<Sheet.Content className={styles.bottomSheet__content}>{children}</Sheet.Content>
</Sheet.Container>
<Sheet.Backdrop className={styles['react-modal-sheet-backdrop']} onTap={props.onClose} />
<Sheet.Backdrop onTap={props.onClose} />
</Sheet>
);
};
4 changes: 2 additions & 2 deletions src/v4/core/components/ConfirmModal/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const Confirm = ({
}
onCancel={onCancel}
>
<div className={styles.confirmModalContent}>{content}</div>
<div>{content}</div>
</Modal>
);

Expand All @@ -61,7 +61,7 @@ export const ConfirmComponent = () => {
confirmData?.onOk && confirmData.onOk();
};

return <Confirm {...confirmData} onCancel={onCancel} onOk={onOk} />;
return <Confirm {...confirmData} onCancel={onCancel} onOk={onOk} className={styles.background} />;
};

export default Confirm;
4 changes: 4 additions & 0 deletions src/v4/core/components/ConfirmModal/styles.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
max-width: 22.5rem !important;
}

.background {
background-color: var(--asc-color-base-background);
}

.footer {
display: flex;
justify-content: flex-end;
Expand Down
5 changes: 3 additions & 2 deletions src/v4/core/components/Modal/styles.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,11 @@

.modalWindow {
margin: auto;
background-color: var(--asc-color-base-background);
border-radius: var(--asc-border-radius-lg);
max-width: 32.5rem;
min-width: 20rem;
/* TOFIX --asc-color-base-background is not defined some how */
background-color: var(--asc-color-white);
}

.modalWindow:focus {
Expand Down Expand Up @@ -71,4 +72,4 @@
.footer {
padding: var(--asc-spacing-m2) var(--asc-spacing-s2);
padding-top: var(--asc-spacing-xxs2);
}
}
Loading
Loading