Avoid hidden failures when dumping #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-muoto
force-pushed
the
capture-any-non-zero-exit-code
branch
2 times, most recently
from
6a82b05 to
43c5008
Compare
max-muoto
commented
Dec 31, 2024
pgclone/run.py
Outdated
| @@ -8,11 +8,24 @@ | |||
| from pgclone import exceptions, logging | |||
|
|
|||
|
|
|||
| def shell(cmd, ignore_errors=False, env=None): | |||
| def _is_pipefail_supported(): | |||
There was a problem hiding this comment.
set -o pipefail is supported in most POSSIX shell implementations at this point, it was added to the spec in 2022 - but the user could still be missing it
max-muoto
changed the title
max-muoto
force-pushed
the
capture-any-non-zero-exit-code
branch
from
39b00f6 to
275923b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently ran into an issue where we were getting silent failures despite
pg_dumpfailing. In particular had a client/server mismatch (client had a version of 16, with the server being on 17) - resulting in us creating empty dumps on S3.This PR sets pipefail when dumping to ensure capture failures in
pg_dump. Currently none of the integration tests interact with S3, but if we want something I'm happy to add something mocking out the storage layer to simulate piping even when dumping locally.