Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(matomocloud): Improve cookieless tracking fallback #1249

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ambroisemaupate
Copy link

This PR should not break compatibility with existing matomocloud service. These features are optional and only triggered when defining parameters above.

… without cookies in fallback. Added `matomoCustomCookieDomain`, `matomoWebsiteDomains` and `matomoFallbackId`
Copy link

stale bot commented Jul 4, 2024

This issue has been automatically marked as inactive because it has not had activity for 20 days. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the inactive label Jul 4, 2024
@AmauriC AmauriC added active and removed inactive labels Jul 4, 2024
@AmauriC
Copy link
Owner

AmauriC commented Jul 12, 2024

Hi,

Thanks for your contribution and sorry for the delay to reply.

On the pro version, this is not possible to set as undefined a string option, so for example tarteaucitron.user.matomoCustomCookieDomain and tarteaucitron.user.matomoFallbackId will be empty and it will break the logic.

Can you change the check from undefined to empty string?

Thanks!

…` and `tarteaucitron.user.matomoFallbackId` against empty string to support Pro version
@ambroisemaupate
Copy link
Author

I've kept tests against undefined and added tests against empty string as requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants