Simplify calls

AmatyaAvadhanula · Oct 18, 2023 · 57b54e6 · 57b54e6
1 parent d98453c
commit 57b54e6
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java b/server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java
@@ -180,25 +180,27 @@ public List<Pair<DataSegment, String>> retrieveUsedSegmentsAndCreatedDates(Strin
         "SELECT created_date, payload FROM %1$s WHERE dataSource = :dataSource AND used = true"
     );
 
+    final List<Interval> intervals = new ArrayList<>();
+    // Do not need an interval condition if the interval is ETERNITY
     if (!Intervals.isEternity(interval)) {
-      SqlSegmentsMetadataQuery.appendConditionForIntervalsAndMatchMode(
-          queryBuilder,
-          ImmutableList.of(interval),
-          SqlSegmentsMetadataQuery.IntervalMode.OVERLAPS,
-          connector
-      );
+      intervals.add(interval);
     }
 
+    SqlSegmentsMetadataQuery.appendConditionForIntervalsAndMatchMode(
+        queryBuilder,
+        intervals,
+        SqlSegmentsMetadataQuery.IntervalMode.OVERLAPS,
+        connector
+    );
+
     final String queryString = StringUtils.format(queryBuilder.toString(), dbTables.getSegmentsTable());
     return connector.retryWithHandle(
         handle -> {
           Query<Map<String, Object>> query = handle
               .createQuery(queryString)
               .bind("dataSource", dataSource);
 
-          if (!Intervals.isEternity(interval)) {
-            SqlSegmentsMetadataQuery.bindQueryIntervals(query, ImmutableList.of(interval));
-          }
+          SqlSegmentsMetadataQuery.bindQueryIntervals(query, intervals);
 
           return query
               .map((int index, ResultSet r, StatementContext ctx) ->