Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk-core): rollback api-mock.ts to use deprecate fetch client from core #2212

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

kpanot
Copy link
Contributor

@kpanot kpanot commented Oct 2, 2024

Proposed change

Rollback api-mock.ts to use deprecate fetch client from core.
This change will be part of #2117.

Related issues

@kpanot kpanot requested a review from a team as a code owner October 2, 2024 01:18
@kpanot kpanot changed the base branch from main to release/11.3.0-rc October 2, 2024 01:18
@github-actions github-actions bot added bug Something isn't working project:@ama-sdk/schematics labels Oct 2, 2024
@@ -1,6 +1,6 @@
{{#apiInfo}}
import { type ApiClient, isApiClient } from '@ama-sdk/core';
import { ApiFetchClient, type BaseApiFetchClientConstructor } from '@ama-sdk/client-fetch';
import { ApiFetchClient, type BaseApiFetchClientConstructor } from '@ama-sdk/core';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep both lines separated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say yes, it is not leading to any issue and will reduce the diff change when migrating to client-fetch :)

@cpaulve-1A cpaulve-1A merged commit 06939a6 into release/11.3.0-rc Oct 2, 2024
30 checks passed
@cpaulve-1A cpaulve-1A deleted the bugfix/fetch-client-import branch October 2, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working project:@ama-sdk/schematics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants