Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: zeroize secret stuff #21

Merged
merged 4 commits into from
Nov 19, 2024
Merged

fix: zeroize secret stuff #21

merged 4 commits into from
Nov 19, 2024

Conversation

varovainen
Copy link
Contributor

  1. zeroize supposedly secret sets of Bits11, some pre-allocations added - can someone actually look through this
  2. bitvec had to go: does not support zeroize; stick to ugly vecs of bools for now
  3. renamed error ErrorWordList to ErrorMnemonic, because it usually has nothing to do with the word list itself

Slesarew
Slesarew reviewed Nov 19, 2024
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
@varovainen @Slesarew
fix: correct division
ef5e44d 
Co-authored-by: Slesarew <[email protected]>
@Slesarew Slesarew merged commit 0b9dae8 into Alzymologist:main Nov 19, 2024
4 checks passed
@varovainen varovainen deleted the va-2024-11-19-add-zeroize branch November 19, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Slesarew Slesarew Slesarew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varovainen @Slesarew