-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Apply strict null checks #14499
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
2a5bfa5
to
f706d8b
Compare
f706d8b
to
30ba2b7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14499 +/- ##
=======================================
Coverage 95.69% 95.69%
=======================================
Files 1893 1893
Lines 24634 24634
Branches 2823 2823
=======================================
Hits 23573 23573
Misses 800 800
Partials 261 261 ☔ View full report in Codecov by Sentry. |
Description
Created a Typescript configuration file for strict null checks and added it to the relevant Github workflow. We can use this to do strict null checks in individual folders until we have covered the whole project and can set
strictNullChecks
totrue
in the maintsconfig
file.Related Issue
Verification