-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: styling in subform table to be more similar the design #14450
Conversation
📝 WalkthroughWalkthroughThis pull request introduces modifications to the frontend language and UI components, focusing on enhancing the display of cell content in a subform table. The changes involve updating a Norwegian translation JSON file, modifying a CSS module for styling, and refactoring a React component to use internationalization (i18n) techniques. The primary goal appears to be improving the rendering and translation of cell content with more flexible formatting. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14450 +/- ##
=======================================
Coverage 95.68% 95.68%
=======================================
Files 1888 1888
Lines 24568 24568
Branches 2820 2820
=======================================
Hits 23509 23509
Misses 799 799
Partials 260 260 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ok in dev
Description
After recent updates to the
StudioDisplayTile
component, the cell content in the subform table no longer matched the intended design in figma.Fixed this replacing the
StudioDisplayTile
withStudioCodeFragment
.Figma
Before
After
Related Issue(s)
Verification
Documentation
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Style
Localization