fix: update path used to get option list ids

[Konrad-Simso]

Description

• Updated path used in frontend to collecting option list ids.
• Removed old endpoint and relevant tests used for collecting ids.

Related Issue

• Clean unused endpoints #14093

Verification

• Your code builds clean without any errors or warnings
• Manual testing done (required)
• Relevant automated test added (if you find this hard, leave it and we'll help out)

Summary by CodeRabbit

• Code Cleanup

  • Removed GetOptionListIds method from the controller.
  • Simplified controller dependencies by removing an unused factory.

• API Changes

  • Updated option list IDs endpoint path from /app-development/option-list-ids to /options.

• Test Removal

  • Deleted unit tests for the removed GetOptionListIds method.

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request involves the removal of the GetOptionListIds method from the AppDevelopmentController in the backend, which simplifies the controller by eliminating the IAltinnGitRepositoryFactory dependency and its associated logic. The corresponding test file for this method has been deleted, and the frontend path for option list IDs has been updated to a more generic endpoint. The modifications streamline the code structure without introducing new functionality.

Changes

File	Change Summary
backend/src/Designer/Controllers/AppDevelopmentController.cs	- Removed IAltinnGitRepositoryFactory dependency - Removed GetOptionListIds method - Updated constructor to remove altinnGitRepositoryFactory parameter
backend/tests/Designer.Tests/Controllers/AppDevelopmentController/GetOptionListIdsTests.cs	- Deleted entire test file for GetOptionListIds method
frontend/packages/shared/src/api/paths.js	- Updated optionListIdsPath function to use a more generic /options endpoint

Possibly related PRs

• fix: accept no options-folder when fetching usage #14409: The changes in this PR also involve the GetOptionListIds method in the AppDevelopmentController, specifically addressing how the method handles scenarios when no option lists are found, which aligns with the removal of the method in the main PR.

Suggested labels

area/content-library

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d95970a and b30b500.

📒 Files selected for processing (1)

• backend/tests/Designer.Tests/Controllers/AppDevelopmentController/GetOptionListIdsTests.cs (0 hunks)

💤 Files with no reviewable changes (1)

• backend/tests/Designer.Tests/Controllers/AppDevelopmentController/GetOptionListIdsTests.cs

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: Run dotnet build and test (macos-latest)
• GitHub Check: Build environment and run e2e test
• GitHub Check: Run dotnet build and test (windows-latest)
• GitHub Check: Analyze
• GitHub Check: Run integration tests against actual gitea and db
• GitHub Check: Run dotnet build and test (ubuntu-latest)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.66%. Comparing base (2f9696e) to head (7098ee7).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #14437   +/-   ##
=======================================
  Coverage   95.66%   95.66%           
=======================================
  Files        1891     1891           
  Lines       24583    24583           
  Branches     2823     2823           
=======================================
  Hits        23517    23517           
  Misses        805      805           
  Partials      261      261           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ErlingHauan]

Good that you noticed this! 👍

[standeren]

⭐