Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dashboard): Improve validation for missing permissions when creating new app #14395

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

feat(dashboard): Improve validation for missing permissions when creating new app #14395

wants to merge 12 commits into from
+272 −19

Conversation

framitdavid
Copy link
Collaborator

@framitdavid framitdavid commented Jan 9, 2025 •
edited
Loading

Description

This PR introduces an error message that informs users when they do not have the necessary permissions to create a repository in a org.

Spiller.inn.2025-01-09.224118.mp4

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/dashboard Area: Related to the dashboard application solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. backend frontend labels Jan 9, 2025
@framitdavid framitdavid changed the title feat(desinger): endpoint to get UserRepositoryPermissions feat(dashboard): Improve validation for missing permissions when creating new app Jan 9, 2025
@framitdavid framitdavid marked this pull request as ready for review January 9, 2025 21:45
@framitdavid framitdavid marked this pull request as draft January 9, 2025 21:45
@framitdavid
Copy link
Collaborator Author

framitdavid commented Jan 9, 2025 •
edited
Loading

Please ignore the backend diff in this PR. This PR dependes on #14389 to be merged first. Since this is a stack upon #14389 14389

@framitdavid framitdavid mentioned this pull request Jan 9, 2025
Open
3 tasks
framitdavid
framitdavid commented Jan 9, 2025
View reviewed changes
backend/src/Designer/Controllers/UserController.cs
@@ -1,5 +1,6 @@
using System.Collections.Generic;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All backend code should be reviewed in another PR: #14389

@framitdavid framitdavid marked this pull request as ready for review January 9, 2025 22:35
@framitdavid framitdavid linked an issue Jan 9, 2025 that may be closed by this pull request
Improve error message for users with insufficient rights #13369
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/dashboard Area: Related to the dashboard application backend frontend quality/testing Tests that are missing, needs to be created or could be improved. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error message for users with insufficient rights
1 participant
@framitdavid