Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove helptext from som properties #14369

Conversation

JamalAlabdullah
Copy link
Contributor

Description

  • Removed helpText for properties; preselectedOptionIndex, showValidations and sortOrder
  • Added trest

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Jan 7, 2025
@JamalAlabdullah JamalAlabdullah changed the title remove helptext from som properties fix: remove helptext from som properties Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.57%. Comparing base (9bfa321) to head (17257a8).
Report is 33 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14369   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files        1862     1862           
  Lines       24135    24141    +6     
  Branches     2785     2788    +3     
=======================================
+ Hits        23066    23072    +6     
  Misses        812      812           
  Partials      257      257           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlqn mlqn self-requested a review January 13, 2025 15:47
Copy link
Contributor

@mlqn mlqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a PR that will handle all help texts here: #14420, so I think this PR can be closed. Feel free to re-open if that is an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants