refactor(studio-root): seperated repeated html on ContactPage to React Component #14169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
solution/studio/designer
wrt95
reviewed
Nov 26, 2024
frontend/studio-root/components/ContactSection/ContactSection.module.css
Outdated
Show resolved
Hide resolved
frontend/studio-root/components/ContactSection/ContactSection.tsx
Outdated
Show resolved
Hide resolved
wrt95
reviewed
Nov 26, 2024
frontend/studio-root/components/ContactSection/ContactSection.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14169 +/- ##
=======================================
Coverage 95.33% 95.33%
=======================================
Files 1783 1785 +2
Lines 23230 23236 +6
Branches 2693 2694 +1
=======================================
+ Hits 22147 22153 +6
Misses 836 836
Partials 247 247 ☔ View full report in Codecov by Sentry. |
framitdavid
added
the
skip-manual-testing
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the ContactPage to improve code readability and maintainability by extracting repeating HTML structures into a separate React component. The extracted component encapsulates shared logic and markup, ensuring the ContactPage remains clean and focused on its specific functionality.
Related Issue(s)
Verification