Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(resource-adm): do not exchange maskinporten token to altinn token when publishing resource #14097

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

mgunnerud
Copy link
Contributor

@mgunnerud mgunnerud commented Nov 18, 2024

Description

  • Exhanging maskinporten token to Altinn token before calling publish resource is no longer needed, as maskinporten token can now be used to call resource registry.

Related Issue(s)

  • this PR

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

… resources, as this conversion is not needed anymore
@mgunnerud mgunnerud added skip-releasenotes Issues that do not make sense to list in our release notes area/resource-adm Issues related to resource administration skip-manual-testing PRs that do not need to be tested manually labels Nov 18, 2024
@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. backend labels Nov 18, 2024
@mgunnerud mgunnerud marked this pull request as ready for review November 19, 2024 12:30
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.32%. Comparing base (d362ec2) to head (12c60cc).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14097   +/-   ##
=======================================
  Coverage   95.32%   95.32%           
=======================================
  Files        1775     1775           
  Lines       23128    23128           
  Branches     2685     2685           
=======================================
  Hits        22047    22047           
  Misses        833      833           
  Partials      248      248           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@TheTechArch TheTechArch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mgunnerud mgunnerud merged commit 3c0cfab into main Nov 21, 2024
17 checks passed
@mgunnerud mgunnerud deleted the chore/publish-resource-fix branch November 21, 2024 10:11
nkylstad pushed a commit that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/resource-adm Issues related to resource administration backend skip-manual-testing PRs that do not need to be tested manually skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants