Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the framework to version 9.0 #684

Merged
merged 96 commits into from
Jan 10, 2025
Merged

Update the framework to version 9.0 #684

merged 96 commits into from
Jan 10, 2025

Conversation

Ahmed-Ghanam
Copy link
Contributor

@Ahmed-Ghanam Ahmed-Ghanam commented Jan 3, 2025 •
edited
Loading

Description

Update the .NET framework to version 9.0

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@Ahmed-Ghanam
Improve the documentation
89887bc
@Ahmed-Ghanam
Improve the documentation and initialization
01eeb3f
@Ahmed-Ghanam
Improve the documentation
43ed855
@Ahmed-Ghanam
Fill in the recipient's name based on whether or not placeholder keyw…
a553fcf 
…ords are used in the template.
@Ahmed-Ghanam
Implemented a new function to retrieve party details for organizations.
9b5cd95
@Ahmed-Ghanam
Extend the lookup logic to check for the recipientNumber keyword
625a92f
@Ahmed-Ghanam
Improve the members documentation
4f172ca
@Ahmed-Ghanam
Add a new property to whether the template contains any recipient num…
cb5cf44 
…ber placeholders
@Ahmed-Ghanam
Improve type documentation
5919ddb
@Ahmed-Ghanam
Eliminate the functions responsible for retrieving the individual nam…
f01b2c8 
…e components.
@Ahmed-Ghanam
Allow the user to send in the components of recipient name when creat…
93e511e 
…ing an order of any type
@Ahmed-Ghanam
Simplify the keywords detection logic
0fb50a2
@Ahmed-Ghanam
Remove the RecipientNameComponents type.
e3ceadc
@Ahmed-Ghanam
Remove the name components
8cc1283
@Ahmed-Ghanam
Remove the unnecessary ConfigureAwait
dbe1a77
@Ahmed-Ghanam
Create a new keyword service to inject actual value wherever a keywor…
a1d13ce 
…d is found
@Ahmed-Ghanam
Update the test data
ea80c49
@Ahmed-Ghanam
Update two functions to retrieve recipient number and recipient name
7c6b427
@Ahmed-Ghanam
Update the sender email address.
6ffb6db
@Ahmed-Ghanam
Save the customized email subject and body in the database
d5d264d
@Ahmed-Ghanam
Pass customized body and subject when trying to send Emails again
3feb865
@Ahmed-Ghanam
Add support for placeholder keywords in SMS
918808d
@Ahmed-Ghanam
Improve the keyword replacement logic
d1391ad
@Ahmed-Ghanam
Replace Regex checks with string.Contains
2bb8102
@Ahmed-Ghanam
Improve the request that we use to retrieve unit details.
a4fb9d5
@Ahmed-Ghanam
Add validation logic to ensure that either organizationNumber or soci…
3003630 
…alSecurityNumber is set at a time.
@Ahmed-Ghanam
Added a constructor for batch creation from existing lists to simplif…
0f3bd1c 
…y usage in client code.
@Ahmed-Ghanam
Update the function that is used to retrieve emails
7b49cbb
@Ahmed-Ghanam
Fix build errors
602b804
@Ahmed-Ghanam
Pass a default value for the new parameters
dfb5241
@Ahmed-Ghanam
Replace the national identity number with an empty string
51aefcf
@Ahmed-Ghanam
Do not replace the $recipientNumber$ with the national identity number
83f31c4
@Ahmed-Ghanam
Compare the keywords using ordinal sort rules
e74c8c4
@Ahmed-Ghanam
Update target framework to 9.0
aa054c3
@Ahmed-Ghanam
Update NuGet packages and remove unused references
53683e4
@Ahmed-Ghanam
Update NuGet packages and remove unused references.
5abcd94
@Ahmed-Ghanam
Remove unused references.
740b198
@Ahmed-Ghanam
Remove unused references and update NuGet packages
78e0000
@Ahmed-Ghanam
Remove unused references and update NuGet packages
9145760
@Ahmed-Ghanam
Remove unused references and update NuGet packages
6bf9037
@Ahmed-Ghanam
Update the Docker image name.
aa90633
@Ahmed-Ghanam
Install Confluent.Kafka package
4fbbe19
@Ahmed-Ghanam
Merge branch 'feature/545-support-placeholder-keywords' into chore/up…
dc6257c 
…date-to-dotnet-9
@Ahmed-Ghanam
Install the Microsoft.NET.Test.Sdk package
9b8f221
SandGrainOne
SandGrainOne reviewed Jan 9, 2025
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
SandGrainOne
SandGrainOne reviewed Jan 9, 2025
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Ahmed-Ghanam Ahmed-Ghanam merged commit 8c06aa4 into main Jan 10, 2025
8 checks passed
@Ahmed-Ghanam Ahmed-Ghanam deleted the chore/update-to-dotnet-9 branch January 10, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SandGrainOne SandGrainOne SandGrainOne approved these changes

Assignees
No one assigned
Labels
review/domain-model-changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ahmed-Ghanam @SandGrainOne