Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added k6 test for sms order #GCPActive #393

Merged
merged 4 commits into from
Feb 8, 2024
Merged

Conversation

acn-sbuad
Copy link
Contributor

@acn-sbuad acn-sbuad commented Jan 25, 2024

Description

Added automated tests to verify sms notificaitons order.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@acn-sbuad acn-sbuad marked this pull request as ready for review January 30, 2024 09:05
@acn-sbuad acn-sbuad requested a review from tba76 January 30, 2024 09:06
acn-sbuad added a commit that referenced this pull request Jan 31, 2024
@acn-sbuad acn-sbuad marked this pull request as draft February 1, 2024 08:48
acn-sbuad added a commit that referenced this pull request Feb 2, 2024
* Core logic for sending SMS to kafka topic #393

* fixed mock

* added unit test for create send notification

* fixed build error

* ensuring topic is defined in test service

* Update ISmsNotificationRepository.cs

---------

Co-authored-by: Thomas Bakken <[email protected]>
@acn-sbuad acn-sbuad marked this pull request as ready for review February 2, 2024 13:58
@acn-sbuad acn-sbuad marked this pull request as draft February 2, 2024 13:58
@acn-sbuad acn-sbuad marked this pull request as ready for review February 5, 2024 12:19
Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@khanrn khanrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@acn-sbuad acn-sbuad merged commit a5a4672 into main Feb 8, 2024
4 checks passed
@acn-sbuad acn-sbuad deleted the chore/automated-tests-sms branch February 8, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants