Introduce a DTO class for UserContactPoints as received from Profile API

src/Altinn.Notifications.Integrations/Profile/Mappers/UserContactPointsDTOMapperExtension.cs

@@ -0,0 +1,27 @@
+using Altinn.Notifications.Core.Models.ContactPoints;
+using Altinn.Notifications.Integrations.Profile.Models;
+
+namespace Altinn.Notifications.Integrations.Profile.Mappers;
+
+/// <summary>
+/// Extension class to map from DTO / Profile API model to domain model for UserContactPoints
+/// </summary>
+public static class UserContactPointsDTOMapperExtension
+{
+    /// <summary>
+    /// Maps the DTO model to domain model
+    /// </summary>
+    /// <param name="userContactPointDto">This DTO object</param>
+    /// <returns>The UserContactPoints object mapped from this DTO object</returns>
+    public static UserContactPoints ToUserContactPoint(this UserContactPointsDTO userContactPointDto)
+    {
+        return new UserContactPoints
+        {
+            UserId = userContactPointDto.UserId ?? 0,
+            NationalIdentityNumber = userContactPointDto.NationalIdentityNumber ?? string.Empty,
+            IsReserved = userContactPointDto.IsReserved,
+            MobileNumber = userContactPointDto.MobileNumber ?? string.Empty,
+            Email = userContactPointDto.Email ?? string.Empty
+        };
+    }
+}

src/Altinn.Notifications.Integrations/Profile/Models/UserContactPointsDTO.cs

@@ -0,0 +1,32 @@
+namespace Altinn.Notifications.Integrations.Profile.Models;
+
+/// <summary>
+/// Data transfer object for the API model describing the availability of contact points for a user, received from the ProfileClient
+/// </summary>
+public class UserContactPointsDTO
+{
+    /// <summary>
+    /// Gets or sets the ID of the user
+    /// </summary>
+    public int? UserId { get; set; }
+
+    /// <summary>
+    /// Gets or sets the national identityt number of the user
+    /// </summary>
+    public string? NationalIdentityNumber { get; set; }
+
+    /// <summary>
+    /// Gets or sets a boolean indicating whether the user has reserved themselves from electronic communication
+    /// </summary>
+    public bool IsReserved { get; set; }
+
+    /// <summary>
+    /// Gets or sets the mobile number
+    /// </summary>
+    public string? MobileNumber { get; set; }
+
+    /// <summary>
+    /// Gets or sets the email address
+    /// </summary>
+    public string? Email { get; set; }
+}

src/Altinn.Notifications.Integrations/Profile/ProfileClient.cs

@@ -7,6 +7,8 @@
 using Altinn.Notifications.Core.Shared;
 using Altinn.Notifications.Integrations.Configuration;
 using Altinn.Notifications.Integrations.Profile;
+using Altinn.Notifications.Integrations.Profile.Mappers;
+using Altinn.Notifications.Integrations.Profile.Models;
 using Altinn.Notifications.Integrations.Register;
 
 using Microsoft.Extensions.Options;
@@ -47,8 +49,9 @@ public async Task<List<UserContactPoints>> GetUserContactPoints(List<string> nat
         }
 
         string responseContent = await response.Content.ReadAsStringAsync();
-        List<UserContactPoints> contactPoints = JsonSerializer.Deserialize<UserContactPointsList>(responseContent, JsonSerializerOptionsProvider.Options)!.ContactPointsList;
-        return contactPoints!;
+        List<UserContactPointsDTO> contactPoints = JsonSerializer.Deserialize<UserContactPointsList>(responseContent, JsonSerializerOptionsProvider.Options)!.ContactPointsList;
+
+        return contactPoints.Select(contactPointDto => contactPointDto.ToUserContactPoint()).ToList();
     }
 
     /// <inheritdoc/>

src/Altinn.Notifications.Integrations/Profile/UserContactPointsList.cs

@@ -1,4 +1,5 @@
 using Altinn.Notifications.Core.Models.ContactPoints;
+using Altinn.Notifications.Integrations.Profile.Models;
 
 namespace Altinn.Notifications.Integrations.Profile;
 
@@ -10,5 +11,5 @@ public class UserContactPointsList
     /// <summary>
     /// A list containing contact points for users
     /// </summary>
-    public List<UserContactPoints> ContactPointsList { get; set; } = [];
+    public List<UserContactPointsDTO> ContactPointsList { get; set; } = [];
 }

test/Altinn.Notifications.Tests/Notifications.Integrations/Profile/ProfileClientTests.cs

@@ -12,6 +12,7 @@
 using Altinn.Notifications.Integrations.Clients;
 using Altinn.Notifications.Integrations.Configuration;
 using Altinn.Notifications.Integrations.Profile;
+using Altinn.Notifications.Integrations.Profile.Models;
 using Altinn.Notifications.Integrations.Register;
 
 using Microsoft.Extensions.Options;
@@ -128,15 +129,15 @@ private Task<HttpResponseMessage> GetUserProfileResponse(UserContactPointLookup
         switch (lookup.NationalIdentityNumbers[0])
         {
             case "empty-list":
-                contentData = new UserContactPointsList() { ContactPointsList = new List<UserContactPoints>() };
+                contentData = new UserContactPointsList() { ContactPointsList = new List<UserContactPointsDTO>() };
                 break;
             case "populated-list":
                 contentData = new UserContactPointsList()
                 {
                     ContactPointsList =
                     [
-                        new UserContactPoints() { NationalIdentityNumber = "01025101038", Email = string.Empty },
-                        new UserContactPoints() { NationalIdentityNumber = "01025101037", Email = string.Empty }
+                        new UserContactPointsDTO() { NationalIdentityNumber = "01025101038", Email = string.Empty },
+                        new UserContactPointsDTO() { NationalIdentityNumber = "01025101037", Email = string.Empty }
                     ]
                 };
                 break;