Rename statuscode to align with altinn-notifications

src/Altinn.Notifications.Sms.Core/Status/SmsSendResult.cs

@@ -41,9 +41,9 @@ public enum SmsSendResult
     Failed_Expired,
 
     /// <summary>
-    /// Sms send operation failed due to invalid receiver
+    /// Sms send operation failed due to invalid recipient e.g. receiver number
     /// </summary>
-    Failed_InvalidReceiver,
+    Failed_InvalidRecipient,
 
     /// <summary>
     /// The SMS was undeliverable (not a valid number or no available route to destination).

src/Altinn.Notifications.Sms.Integrations/LinkMobility/SmsClient.cs

@@ -43,7 +43,7 @@ public async Task<Result<string, SmsClientErrorResponse>> SendAsync(Core.Sending
 
             if (result.StatusText.StartsWith("Invalid RCV"))
             {
-                return new SmsClientErrorResponse { SendResult = SmsSendResult.Failed_InvalidReceiver, ErrorMessage = result.StatusText };
+                return new SmsClientErrorResponse { SendResult = SmsSendResult.Failed_InvalidRecipient, ErrorMessage = result.StatusText };
             }
 
             _logger.LogInformation("// SmsClient // SendAsync // Failed to send SMS. Status: {StatusText}", result.StatusText);

test/Altinn.Notifications.Sms.Tests/Sms.Core/Sending/SendingServiceTests.cs

@@ -47,22 +47,22 @@ public async Task SendAsync_GatewayReferenceGenerated_SendingAccepted()
     }
 
     [Fact]
-    public async Task SendAsync_InvalidReceiver_PublishedToExpectedKafkaTopic()
+    public async Task SendAsync_InvalidRecipient_PublishedToExpectedKafkaTopic()
     {
         // Arrange
         Guid id = Guid.NewGuid();
         Notifications.Sms.Core.Sending.Sms sms = new(id, "sender", "recipient", "message");
 
         Mock<ISmsClient> clientMock = new();
         clientMock.Setup(c => c.SendAsync(It.IsAny<Notifications.Sms.Core.Sending.Sms>()))
-        .ReturnsAsync(new SmsClientErrorResponse { SendResult = SmsSendResult.Failed_InvalidReceiver, ErrorMessage = "Receiver is wrong" });
+        .ReturnsAsync(new SmsClientErrorResponse { SendResult = SmsSendResult.Failed_InvalidRecipient, ErrorMessage = "Receiver is wrong" });
 
         Mock<ICommonProducer> producerMock = new();
         producerMock.Setup(p => p.ProduceAsync(
             It.Is<string>(s => s.Equals(nameof(_topicSettings.SmsStatusUpdatedTopicName))),
             It.Is<string>(s =>
             s.Contains($"\"notificationId\":\"{id}\"") &&
-            s.Contains("\"sendResult\":\"Failed_InvalidReceiver\""))));
+            s.Contains("\"sendResult\":\"Failed_InvalidRecipient\""))));
 
         var sut = new SendingService(clientMock.Object, producerMock.Object, _topicSettings);
 

test/Altinn.Notifications.Sms.Tests/Sms.Integrations/SmsClientTests.cs

@@ -72,7 +72,7 @@ await result.Match(
               async actualErrorResponse =>
               {
                   await Task.CompletedTask;
-                  Assert.Equal(SmsSendResult.Failed_InvalidReceiver, actualErrorResponse.SendResult);
+                  Assert.Equal(SmsSendResult.Failed_InvalidRecipient, actualErrorResponse.SendResult);
                   Assert.NotNull(actualErrorResponse.ErrorMessage);
               });
         }