[d3d8] Validate depth stencil format use with CopyRects #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WinterSnowfall
force-pushed
the
d8vk-crdsf
branch
2 times, most recently
from
84eca41
to
9522ef7
Compare
AlpyneDreams
force-pushed
the
main
branch
3 times, most recently
from
9b44e13
to
9ebed42
Compare
WinterSnowfall
force-pushed
the
d8vk-crdsf
branch
2 times, most recently
from
b8180aa
to
0a37972
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now
CopyRects()succeeds in d8vk if invoked with depth stencil surfaces.Upstream dxvk will soon add several validations on StretchRect() calls in combination with depth stencils, which could interfere with its use on our end in
CopyRects(), however the good news is that the d3d8 documentation states that:I have written a test, and it looks like WineD3D does indeed respect it, so we should as well, if only to avoid unnecessary d3d9 calls that are bound to fail in the future anyway.
Edit: Native Nvidia also does this validation.