[d3d8] Use D3DPOOL_SCRATCH in CreateImageSurface #206
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89 and fixes points (1.) and (2.) from #205.
Some games expect us to successfully create image surfaces for them even when they supply unsupported formats like
P8
orR8G8B8
. This only works withD3DPOOL_SCRATCH
according to spec, and it's also what dxvk validates inside ofCreateOffscreenPlainSurfaceEx()
.We don't actually need to fully support them in order for the above games to work properly at least. #182 will still need
P8
support, since it uses that onCreateTexture()
.The only problem is we don't currently handle
D3DPOOL_SCRATCH
at all inCopyRects()
, so this has the potential to explode and break more than it fixes. We should merge this change only after sorting out that bit ideally.