[d3d8] Handle DEFAULT->MANAGED in CopyRects #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WinterSnowfall
force-pushed
the
d8vk-copyrects
branch
from
837bc1f
to
e31f4ef
Compare
|
I've also taken the liberty to make CopyRects logging more verbose on unhandled cases, since we ideally would want to see these sort of problems in the logs that people send us. |
WinterSnowfall
force-pushed
the
d8vk-copyrects
branch
from
308d26f
to
c6d3f82
Compare
AlpyneDreams
force-pushed
the
main
branch
3 times, most recently
from
9b44e13
to
9ebed42
Compare
WinterSnowfall
force-pushed
the
d8vk-copyrects
branch
from
c6d3f82
to
875b2b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arguably not ideal, but having some way of handling it is better than derping out and doing nothing. We can always implement a GPU copy later on to optimize peformance, but for now handling MANAGED as we do SYSTEMMEM seems to do the trick and fixes #66 (which has bugged me for quite some time).
Without PR
With PR
DEFAULT->MANAGED doesn't seem to be a very hot path, but there are games out there that will hit it occasionally.