Fix disappearing shadows #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using all tiles for calculating shadow maps fixes problems with shadows, but comes with (minor) performance hit should do culling with light source's view frustum in future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The set of tiles used for calculating the shadow maps was culled with the camera's view frustum. Therefore, shadows cast by objects outside of the view frustum were not visible.
This PR fixes the issue by (per default) including all tiles when calculating the shadow maps. This adds a slight performance penalty, but improves the visual quality.
Culling of the tiles for shadow mapping can be toggled by pressing the V key, although, enabling it only culls the tiles by the camera view frustum and not be the light source view frustum, resulting in the same behaviour as before.
Additionally, you can toggle a debug camera view with F12 and view frustum culling for tiles to draw with C.
This PR serves as a basis for possibly further improving performance and quality by