Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last fixes and additions #58

Closed
wants to merge 33 commits into from
Closed

Last fixes and additions #58

wants to merge 33 commits into from

Conversation

GeraldKimmersdorfer
Copy link
Contributor

Heyho this pr fixes a bunch of things and adds the possibility to switch to fullscreen on native build by pressing F11.

Should be the last push from my side in terms of the fancy map project.

GeraldKimmersdorfer and others added 16 commits November 20, 2023 11:33
@GeraldKimmersdorfer
adds fullscreen toggle F11 on desktop targets
97b662b
@GeraldKimmersdorfer
adds "old" preset selection combobox to stats window again
c02d778
@adam-ce
reenable windows
58d2e80
@adam-ce
disable linux for now
0d07aa3
@adam-ce
fix arch
1048470
@adam-ce
try using newer aqt verversion
e50eda8
@adam-ce
fix do not declare C VLA arrays, use std::vector<> instead [cppcoregu…
4fb0bcf 
…idelines-avoid-c-arrays]

this should also fix compilation on msvc
@adam-ce
same as the previous commit, just different instance.
e2dc4ad
@GeraldKimmersdorfer
moves height lines to compose and fixes shadow map overlays
b6da664
@GeraldKimmersdorfer
adds hotkey indicators to menu entries
73c797b
@adam-ce
same as the previous commit, just different instance.
68fe4aa
@GeraldKimmersdorfer
fixes error on webgl and removes possibility to disable/enable tile s…
fea24dc 
…orting per F7 (now default)
@adam-ce
cmd shell needs the start command
323adbb
@GeraldKimmersdorfer
Merge remote-tracking branch 'upstream/main' into develop
d24a53d
@adam-ce
i don't see whether the tests were started with cmd
38460d5
@adam-ce
extend/update style guide
752c430
@adam-ce
Copy link
Member

adam-ce commented Nov 24, 2023

The F11 toggle looks a lot like spaghetti code to me:

  • Rendering thread notifier is pulled in to do something it has no concern with
  • TerrainRenderItem too, in the future we could use for rendering a small preview of map changes. having the fullscreen code would be one more thing we would have to clean out before that works.
  • the same change can be done in main_loader.qml in 13 lines (not touching so many different files).

I propose to revert that commit, and I'll merge my F11 version separately.

@adam-ce
Copy link
Member

adam-ce commented Nov 24, 2023

the rest of the changes are super cool :)

@adam-ce
Merge pull request AlpineMapsOrg#59 from AlpineMapsOrg/fullscreen_toggle
839362f 
f11 toggles fullscreen (tested on desktop, on webassembly the behavio…
adam-ce
adam-ce requested changes Nov 27, 2023
View reviewed changes
Copy link
Member

@adam-ce adam-ce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment before

@adam-ce adam-ce closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam-ce adam-ce adam-ce requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeraldKimmersdorfer @adam-ce