fix: listen for changes in layout bounds in FXGLDefaultMenu.kt #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bart-del
force-pushed
the
dev
branch
2 times, most recently
from
6dd326a to
8d5c543
Compare
AlmasB
requested changes
Dec 18, 2024
|
|
||
| val titleWidth = firstLetterWidth + restOfTheTitleWidth | ||
|
|
||
| val border = Rectangle(titleWidth + 30, 65.0, null) |
There was a problem hiding this comment.
The width of this rectangle is still fixed, it should be updated based on changes to layout bounds of the text objects. Something like:
firstLetter.layoutBoundsProperty().addListener { _, _, newBounds -> update border width }
| box.alignment = Pos.CENTER | ||
|
|
||
| val titleRoot = StackPane(border, box) | ||
| titleRoot.translateX = appWidth / 2.0 - (textWidth + 30) / 2 | ||
| titleRoot.translateX = appWidth / 2.0 - (titleWidth + 30) / 2 |
There was a problem hiding this comment.
The translateX property should also be bound to the new value of restOfTheTitle layout bounds. Something like:
firstLetter.layoutBoundsProperty().addListener { _, _, newBounds -> update titleRoot translateX }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Issue link: #1020
This PR contains fix for title width calculation. Now it will listen for changes in layoutBounds and should update title width when font size will change. I've also changed the variable names to be more descriptive.