Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SMALLFIX]Fix logging message AbstractCollectInfoCommand.java #15246

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

Sucran
Copy link
Contributor

@Sucran Sucran commented Apr 1, 2022

What changes are proposed in this pull request?

Please outline the changes and how this PR fixes the issue.

change
LOG.debug("Command %s works in %s", this.getCommandName(), workingDirPath);
to
LOG.debug("Command {} works in {}", this.getCommandName(), workingDirPath);
since this is logging format, so it support {} grammer.

Why are the changes needed? just small fix.

Please clarify why the changes are needed. For instance,

  1. If you propose a new API, clarify the use case for a new API.
  2. If you fix a bug, describe the bug. 3.

Does this PR introduce any user facing changes? no

Please list the user-facing changes introduced by your change, including

  1. change in user-facing APIs
  2. addition or removal of property keys
  3. webui

change
LOG.debug("Command %s works in %s", this.getCommandName(), workingDirPath);
to
LOG.debug("Command {} works in {}", this.getCommandName(), workingDirPath);
since this is logging format, so it support {} grammer.

Closes Alluxio#629
@alluxio-bot
Copy link
Contributor

Hi @Sucran, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@alluxio-bot
Copy link
Contributor

You did it @Sucran!

Thank you for signing the Contribution License Agreement.

@Sucran
Copy link
Contributor Author

Sucran commented Apr 1, 2022

fix the issue of Alluxio/Community#629

Copy link
Contributor

@HelloHorizon HelloHorizon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Sucran . LGTM

@HelloHorizon
Copy link
Contributor

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit 08eac26 into Alluxio:master Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants