Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for adding attachments #21

Merged
merged 5 commits into from
Jul 23, 2024
Merged

add support for adding attachments #21

merged 5 commits into from
Jul 23, 2024

Conversation

mochic
Copy link
Collaborator

@mochic mochic commented Jul 19, 2024

Adds support for adding attachments to models.

jtyoung84
jtyoung84 reviewed Jul 22, 2024
View reviewed changes
tests/test_core.py Outdated Show resolved Hide resolved
jtyoung84
jtyoung84 reviewed Jul 22, 2024
View reviewed changes
tests/test_core.py Outdated Show resolved Hide resolved
jtyoung84
jtyoung84 reviewed Jul 22, 2024
View reviewed changes
tests/test_core.py Outdated Show resolved Hide resolved
jtyoung84
jtyoung84 requested changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@jtyoung84 jtyoung84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small things to make the unit tests use the same patch framework

@jtyoung84 jtyoung84 merged commit 55bd958 into AllenNeuralDynamics:main Jul 23, 2024
3 checks passed
@mochic mochic mentioned this pull request Jul 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patricklatimer patricklatimer patricklatimer approved these changes

@jtyoung84 jtyoung84 jtyoung84 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mochic @jtyoung84 @patricklatimer