Enh/attachments #20

mochic · 2024-07-11T20:18:21Z

Adds support for attachments.

…ssary?

src/aind_slims_api/__init__.py

src/aind_slims_api/models/attachment.py

jtyoung84 · 2024-07-18T00:58:30Z

src/aind_slims_api/models/utils.py

+
+    def __init__(self, *args, preferred_unit=None):
+        """Set list of acceptable units from args, and preferred_unit"""
+        self.units = args


I get a type warning. args is a tuple, but it's expecting a list.

src/aind_slims_api/core.py

src/aind_slims_api/types.py

jtyoung84

I'd recommend separating the doc tests into a separate PR. I get unusual behavior trying to run them locally.
An error is raised when I try to fetch an attachment that doesn't exist. It'd be nice if I got something similar to a 404 response.
My IDE highlights a few warnings about types, static methods, and accessing protected attributes

mochic · 2024-07-18T18:58:32Z

fetching attachment that doesn't exist has been resolved in d621742

…ts-tests-update tests: mocked log info and fixed type warning

…nh/general-improvements

mochic added 20 commits July 11, 2024 03:14

add support for attachments

2b69f6f

add support for attachments

154b39c

docs, whitespace

5e96ecd

push for sharing

5a3d60e

add conditional slim_api for reserialization testing? or maybe unnece…

eca7767

…ssary?

revert change

54cf4c8

add model alias fetching

a5fd7ac

only return validated data

3a918c1

use alias for sort key

59edb41

whitespace

760ca39

new attachments iteration

ae4aec7

new attachments implementation

a5eff9d

doctest example for model

680ff25

new core

ac0cd43

use doctests, remove fetches

51ce1d2

coverage

21183bd

documentation

d48a21a

update docs

32492de

formatting

8a76f0a

add usage example

7ef9343

patricklatimer approved these changes Jul 17, 2024

View reviewed changes

mochic added 2 commits July 17, 2024 14:57

rework models

081908b

update example usage

5b8d277