-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add docdb utils #57
Conversation
src/aind_data_access_api/utils.py
Outdated
from pymongo import MongoClient | ||
|
||
|
||
def is_prefix_valid(prefix: str) -> bool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this the only function that is requires aind-data-schema, it might be better to remove it and the aind-data-schema dependency for the time being. At the very least, since this package will probably be imported alongside other packages, it will be problematic if the version of aind-data-schema is pinned to a specific version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is_record_location_valid
uses this function to check that the location field contains a valid data asset name. Should I also remove that check from is_record_location_valid
for the time being?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, let's do those in a separate PR (if needed). Hopefully, people shouldn't be modifying the location.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, I removed those two functions.
closes #48