[WIP] Enh/58 interpolation methods #60

mochic · 2017-12-16T01:40:38Z

[WIP] attempts to address #58

I have some issues currently. Let me know what you think.

neuroglia.interpolator.kriging_interpolator_factory looks strange to me, there has to be a better way to do this
I can't seem successfully to test neuroglia.interpolator.sinc_interpolator_factory against justin kiggins's test data
I don't know if setting the builtin interpolators as a namedtuple class attribute is the best functionality but I currently like coupling them together in this way

neuromusic

approving merging this into a branch in this repo until we can revisit development on these methods

neuromusic · 2017-12-18T22:28:03Z

neuroglia/event.py

        self.sample_times = sample_times
        self.traces = traces

+        if isinstance(interpolator, string_types):


the logic here risks breaking compatability with scikit-learn infrastructure. see http://scikit-learn.org/0.16/developers/index.html#instantiation

mochic added 3 commits December 15, 2017 15:19

removed create_interpolator, pep styling

c4c0894

added builtin interpolators, kriging looks weird...

657abd1

added interpolator functionality, pep8 style

3619c0f

mochic added the enhancement label Dec 16, 2017

mochic requested review from nicain and neuromusic December 16, 2017 01:40

mochic added the help wanted label Dec 19, 2017

neuromusic changed the base branch from master to feature/more_interpolation March 16, 2018 19:13

neuromusic approved these changes Mar 16, 2018

View reviewed changes

neuromusic merged commit 73755c2 into AllenInstitute:feature/more_interpolation Mar 16, 2018

Provide feedback