Enhance adaptive suprathreshold #2302
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-b
force-pushed
the
feature/2302-another-adaptive-revision
branch
from
daec7e1 to
886e9e6
Compare
t-b
force-pushed
the
feature/2302-another-adaptive-revision
branch
2 times, most recently
from
d7b9af8 to
7a4e927
Compare
…sweeps The new FailingAdaptiveSCIRange analysis parameter allows to tune the formerly hardcoded (1) number of SCIs we look back for failing adaptive sets. It defaults to 1, can be turned off with 0 and allows inf for always taking all SCIs into account.
We don't need the sub pA precision. In PSQ_DS_GatherOvershootCorrection we now also check if the calulated value is the same as the before/after value, as this can now happen with rounding. In PSQ_DS_CalculateDAScale we also use ceil for the too large/small cases so that we always get a different value.
We now perform the already measured check only if we have a candidate at all.
Debugging the future DAScales labnotebook entries can be challenging as it is not obvious form where the values where added. We now fix that by adding a type to the futureDAScales waves which is then also stored in the labnotebook.
t-b
force-pushed
the
feature/2302-another-adaptive-revision
branch
from
7a4e927 to
d70dcac
Compare
Both variants for the adaptive data and for RhSuAd.
For a future application we want to check for something different than equality, so making the predicate configurable here is required.
…PSQ_FMT_LBN_SWEEP_PASS This has a different explanation but in this sense it is never used. Introduced in c53b5d0 (PSQ_DaScale: Enhance adaptive mode, 2024-07-26).
Having a duplicate version for PSQ_DAScale Adaptive makes it easier to check if we have all variants (offsets, RhSuAd, DAScale, etc.) properly done.
…out baseline QC Needed for a future application.
- Ignore sweeps with negative fI slopes for the DAScale estimation
- Store a new QC value if the fI slope is finite and negative
- Using this new QC we are now also done if:
- We have to consecutive negative fI slope values (as usual failing
sweep QC sweeps can be in between)
- or we have a passing fI slope and a consecutive (as above) negative fI
slope value
If we finish due to these two conditions we also fillin another DAScale
in between the positive FI slope sweep and the first negative fI slope
value.
- We now use the new analysis parameter DAScaleNegativeSlopePercent,
defaulting to 50%, to calculate a new DAScale value after a negative
slope. We use the percentage of the maximum DAScale step for that.
The stock Igor Pro functions don't maintain the relative order of the same key values. So we had to roll our own.
t-b
force-pushed
the
feature/2302-another-adaptive-revision
branch
from
d70dcac to
87bc99b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2258