-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to allensdk for MultiscopeSignalNoise and TaskTrainedNetworksMultiscope data #2278
Open
mabuice
wants to merge
46
commits into
AllenInstitute:master
Choose a base branch
from
mabuice:mesoscope-mabuice
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e the syncfile since not all mesoscope data has behavior stimulus information in the pkl file, so we can't use .from_stimulus_file
…ior mesoscope data
…of behavior session
…ksMultiscope data
…toring due to key changes for TaskTrainedNetworksMultiscope
…for TaskTrainedNetworksMultiscope data
… find a different solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
This is an update to the allensdk that allows loading and using data from the MultiscopeSignalNoise and TaskTrainedNetworkMultiscope datasets.
Addresses:
This adds a few new classes (labeled 'visualcoding***') next to the behavior classes for multiscope data. These load from ophys_session_ids so one of the main additions is several classes now have a method .from_lims_for_ophys_session that loads the corresponding data from LIMS using an ophys_session_id rather than a behavior_session_id (since not all of the data has behavior_session_ids).
It also adds the computation of the stimulus presentation table for these data. Templates are left as paths to the correct template on the internal servers for now due to file size.
This update also addresses an issue with line_label changes.
You probably want to merge this into its own branch rather than into master, if at all right now. I'm submitting this pull request so that the team has visibility on this.
Type of Fix:
Added classes and methods to existing classes.
Changes:
Added files such as 'visualcoding_session.py', 'visualcoding_ophys_experiment.py', 'visualcoding_metadata.py', 'visualcoding_session_id.py', 'visual_coding_session_type.py', 'densemovie_presentations.py', 'densemovie_stimuli.py', 'densemovie_templates.py'.
Also added .from_lims_for_ophys_session method to many classes that used .from_lims (with a behavior_session_id).