-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more documentation to the main README and development infos #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frcroth
requested changes
Aug 31, 2022
sirkrypt0
force-pushed
the
feature/more-doc
branch
from
August 31, 2022 13:50
9e5b09a
to
3897d1b
Compare
sirkrypt0
force-pushed
the
feature/more-doc
branch
2 times, most recently
from
August 31, 2022 14:05
657fa24
to
3959752
Compare
konradh
approved these changes
Aug 31, 2022
frcroth
approved these changes
Aug 31, 2022
felix-gohla
requested changes
Aug 31, 2022
sirkrypt0
force-pushed
the
feature/more-doc
branch
from
August 31, 2022 16:50
3959752
to
6b4c3f8
Compare
felix-gohla
requested changes
Aug 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some further things that came to my mind: The crypto implementations probably aren't completely safe (think of the AES-GCM code). We should note this somewhere.
Also: please add building instructions for x86.
Closed
6 tasks
felix-gohla
reviewed
Aug 31, 2022
sirkrypt0
force-pushed
the
feature/more-doc
branch
2 times, most recently
from
August 31, 2022 17:24
5ee7c05
to
c66fbe3
Compare
felix-gohla
approved these changes
Aug 31, 2022
sirkrypt0
force-pushed
the
feature/more-doc
branch
from
August 31, 2022 17:32
c66fbe3
to
ca343e2
Compare
felix-gohla
requested changes
Aug 31, 2022
sirkrypt0
force-pushed
the
feature/more-doc
branch
from
August 31, 2022 17:40
ca343e2
to
0972490
Compare
sirkrypt0
force-pushed
the
feature/more-doc
branch
from
August 31, 2022 17:42
0972490
to
665ff13
Compare
The library can also be built for desktops, so why not mention it?
sirkrypt0
force-pushed
the
feature/more-doc
branch
from
August 31, 2022 17:54
c2b6847
to
a60b5c9
Compare
felix-gohla
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.