Enable custom RNG implementations #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we used the wrong format strings for displaying the amount of clock cycles and nanoseconds.
frcroth
reviewed
Aug 31, 2022
sirkrypt0
force-pushed
the
feature/enable-custom-rng
branch
from
74bff97 to
969dd9f
Compare
frcroth
reviewed
Aug 31, 2022
sirkrypt0
force-pushed
the
feature/enable-custom-rng
branch
from
969dd9f to
460c531
Compare
felix-gohla
requested changes
Aug 31, 2022
sirkrypt0
force-pushed
the
feature/enable-custom-rng
branch
from
460c531 to
603d6e7
Compare
Previously, the RNG implementation was provided by us, with no way to overwrite it. Similar to the cryptographic algorithms, users can now overwrite the RNG implementation by setting USE_SOFTWARE_RNG to false and setting the fido_get_random function in random.h accordingly. This is especially useful when using a board that provides a hardware RNG.
sirkrypt0
force-pushed
the
feature/enable-custom-rng
branch
from
603d6e7 to
ecf80f2
Compare
frcroth
approved these changes
Aug 31, 2022
felix-gohla
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to how custom crypto implementations can be used, this enables users to overwrite the RNG function.
Closes #41