Merge/cleanup renderer viewport calculation code. #496
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes numerous comments complaining about
fix_viewport_ratio
being used in render functions by instead calculating the viewport whenever the window is resized with a new, similar function in graphics.c. Doing this also allows the integer scaling state to be precalculated for all scaling renderers, which helps mainlyopengl2
right now (but could be extended toopengl1
andglsl
). The longstanding "FIXME" about the ratio being calculated using floats has also been resolved.There are two places where this couldn't be fully fixed:
opengl2
andglsl
using the viewport variables inrender_layer
to set the viewport every time a layer is rendered. Doing this correctly requires a new start of frame callback, which would be a good idea for other reasons (charset and palette update).get_screen_coords_scaled
/set_screen_coords_scaled
also need to use the new render viewport variables.fix_viewport_ratio
to generate the viewport in an unusal way and it needs to be converted.