Addition of subjective pronouns. #205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per my issue post #204 questions assume the presence of a prononoun preceding the question. I noticed this pronoun is excluded in the downstream application as well, so here I attempted to find them for each language. There are probably a lot of mistakes and these translations need to be looked at in the context of the questions. Worth noting that the translations are very mixed between including a pronoun and excluding it. For example: Swedish, Norwegian, Danish, English, Dutch, Italian and Portuguese all seem to exclude them, while Icelandic, German, Estonian and French all seem to include them. Ideally this is standardised in future translations and edits. This change makes them accessible under the getInfo() call.
|
Kudos, SonarCloud Quality Gate passed!
|
|
Thank you for your interest in this module. We do not provide pronouns simply because they are not used in the original items https://ipip.ori.org/30facetneo-pi-ritems.htm It is important to us to change any of the questions from the inventory. If you wish to add this feature to your own solution you could build a wrapper around this module. Any other thoughts regarding this @maccyber ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per my issue post #204 questions assume the presence of a prononoun preceding the question. I noticed this pronoun is excluded in the downstream application as well, so here I attempted to find them for each language. There are probably a lot of mistakes and these translations need to be looked at in the context of the questions.
Worth noting that the translations are very mixed between including a pronoun and excluding it. For example: Swedish, Norwegian, Danish, English, Dutch, Italian and Portuguese all seem to exclude them, while Icelandic, German, Estonian and French all seem to include them. Ideally this is standardised in future translations and edits.
This change makes them accessible under the getInfo() call which makes sense to me as you can grab and store them once per language, at the same time as the answer option translations. It may or may not make sense to also include a flag for whether the questions for the language in question already includes the pronoun.