Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACS-6307 Implement SAST pipeline scan #746

Merged

Conversation

mikolajbrzezinski
Copy link
Contributor

No description provided.

Copy link



Scan Summary:
PIPELINE_SCAN_VERSION: 23.11.0-0
DEV-STAGE: DEVELOPMENT
PROJECT-NAME: gytheio
SCAN_ID: 1cf1278a-c0e9-417f-b645-0aadf8cdfb71
SCAN_STATUS: SUCCESS
SCAN_MESSAGE: Scan successful. Results size: 16600 bytes
====================
Analysis Successful.
====================

===========================
Found 14 Scannable modules.
===========================
gytheio-commons/target/gytheio-commons-0.20.0-A2-SNAPSHOT-tests.jar
gytheio-content-handlers/gytheio-content-handler-s3/target/gytheio-content-handler-s3-0.20.0-A2-SNAPSHOT.jar
gytheio-content-handlers/gytheio-content-handler-tempfile/target/gytheio-content-handler-tempfile-0.20.0-A2-SNAPSHOT.jar
gytheio-hash/gytheio-hash-worker-javase/target/gytheio-hash-worker-javase-0.20.0-A2-SNAPSHOT.jar
gytheio-messaging/gytheio-messaging-benchmark/target/gytheio-messaging-benchmark-0.20.0-A2-SNAPSHOT.jar
gytheio-messaging/gytheio-messaging-camel/target/gytheio-messaging-camel-0.20.0-A2-SNAPSHOT.jar
gytheio-messaging/gytheio-messaging-commons/target/gytheio-messaging-commons-0.20.0-A2-SNAPSHOT.jar
gytheio-node-simple/target/gytheio-node-simple-0.20.0-A2-SNAPSHOT.jar
gytheio-transform/gytheio-transform-commons/target/gytheio-transform-commons-0.20.0-A2-SNAPSHOT-tests.jar
gytheio-transform/gytheio-transform-commons/target/gytheio-transform-commons-0.20.0-A2-SNAPSHOT.jar
gytheio-transform/gytheio-transform-component/target/gytheio-transform-component-0.20.0-A2-SNAPSHOT.jar
gytheio-transform/gytheio-transform-messaging/target/gytheio-transform-messaging-0.20.0-A2-SNAPSHOT.jar
gytheio-transform/gytheio-transform-worker-ffmpeg/target/gytheio-transform-worker-ffmpeg-0.20.0-A2-SNAPSHOT.jar
gytheio-transform/gytheio-transform-worker-imagemagick/target/gytheio-transform-worker-imagemagick-0.20.0-A2-SNAPSHOT.jar

====================
Analyzed 14 modules.
====================
gytheio-commons/target/gytheio-commons-0.20.0-A2-SNAPSHOT-tests.jar
gytheio-content-handlers/gytheio-content-handler-s3/target/gytheio-content-handler-s3-0.20.0-A2-SNAPSHOT.jar
gytheio-content-handlers/gytheio-content-handler-tempfile/target/gytheio-content-handler-tempfile-0.20.0-A2-SNAPSHOT.jar
gytheio-hash/gytheio-hash-worker-javase/target/gytheio-hash-worker-javase-0.20.0-A2-SNAPSHOT.jar
gytheio-messaging/gytheio-messaging-benchmark/target/gytheio-messaging-benchmark-0.20.0-A2-SNAPSHOT.jar
gytheio-messaging/gytheio-messaging-camel/target/gytheio-messaging-camel-0.20.0-A2-SNAPSHOT.jar
gytheio-messaging/gytheio-messaging-commons/target/gytheio-messaging-commons-0.20.0-A2-SNAPSHOT.jar
gytheio-node-simple/target/gytheio-node-simple-0.20.0-A2-SNAPSHOT.jar
gytheio-transform/gytheio-transform-commons/target/gytheio-transform-commons-0.20.0-A2-SNAPSHOT-tests.jar
gytheio-transform/gytheio-transform-commons/target/gytheio-transform-commons-0.20.0-A2-SNAPSHOT.jar
gytheio-transform/gytheio-transform-component/target/gytheio-transform-component-0.20.0-A2-SNAPSHOT.jar
gytheio-transform/gytheio-transform-messaging/target/gytheio-transform-messaging-0.20.0-A2-SNAPSHOT.jar
gytheio-transform/gytheio-transform-worker-ffmpeg/target/gytheio-transform-worker-ffmpeg-0.20.0-A2-SNAPSHOT.jar
gytheio-transform/gytheio-transform-worker-imagemagick/target/gytheio-transform-worker-imagemagick-0.20.0-A2-SNAPSHOT.jar

==================
Analyzed 7 issues.
==================

details


----------------------------------
Found 4 issues of Medium severity.
----------------------------------
CWE-73: External Control of File Name or Path: org/gytheio/content/node/SimpleAmqpNodeBootstrap.java:72
Details: This call to java.io.FileInputStream.!operator_javanewinit() contains a path manipulation flaw. The argument to the function is a filename constructed using untrusted input. If an attacker is allowed to specify all or part of the filename, it may be possible to gain unauthorized access to files on the server, including those outside the webroot, that would be normally be inaccessible to end users. The level of exposure depends on the effectiveness of input validation routines, if any. The first argument to !operator_javanewinit() contains tainted data from the variable propertiesFilePath. The tainted data originated from an earlier call to org.gytheio.content.node.SimpleAmqpNodeBootstrap.main. Validate all untrusted input to ensure that it conforms to the expected format, using centralized data validation routines when possible. When using blocklists, be sure that the sanitizing routine performs a sufficient number of iterations to remove all instances of disallowed characters. References: CWE OWASP
https://downloads.veracode.com/securityscan/cwe/v4/java/73.html
CWE-470: Use of Externally-Controlled Input to Select Classes or Code ('Unsafe Reflection'): org/gytheio/content/node/SimpleAmqpNodeBootstrap.java:108
Details: This call to java.lang.ClassLoader.loadClass() uses reflection in an unsafe manner. An attacker can specify the class name to be instantiated, which may create unexpected control flow paths through the application. Depending on how reflection is being used, the attack vector may allow the attacker to bypass security checks or otherwise cause the application to behave in an unexpected manner. Even if the object does not implement the specified interface and a ClassCastException is thrown, the constructor of the untrusted class name will have already executed. The first argument to loadClass() contains tainted data from the variable workerClassName. The tainted data originated from an earlier call to java.io.FileInputStream.!ctor. Validate the class name against a combination of white and blocklists to ensure that only expected behavior is produced. References: CWE OWASP
https://downloads.veracode.com/securityscan/cwe/v4/java/470.html
CWE-256: Plaintext Storage of a Password: org/gytheio/content/node/AbstractComponentBootstrapFromProperties.java:92
Details: The java.util.Properties.getProperty() method reads and/or stores sensitive information in plaintext, making the data more susceptible to compromise. Never store sensitive data in plaintext. Consider using cryptographic hashes as an alternative to plaintext. References: CWE
https://downloads.veracode.com/securityscan/cwe/v4/java/256.html
CWE-256: Plaintext Storage of a Password: org/gytheio/content/node/AbstractComponentBootstrapFromProperties.java:93
Details: The java.util.Properties.getProperty() method reads and/or stores sensitive information in plaintext, making the data more susceptible to compromise. Never store sensitive data in plaintext. Consider using cryptographic hashes as an alternative to plaintext. References: CWE
https://downloads.veracode.com/securityscan/cwe/v4/java/256.html
----------------------------------
Skipping 3 issues of Low severity.
----------------------------------


========================
FAILURE: Found 4 issues!
========================

[28 Nov 2023 11:30:43,0594] PIPELINE-SCAN INFO: Writing Scan Summary to file '/home/runner/work/gytheio/gytheio/readable_results.txt'.

@mikolajbrzezinski mikolajbrzezinski merged commit 4a2b595 into master Dec 13, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants