Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACS-6450 Dynamically determine ARM64 LibreOffice download link #923

Merged

Conversation

mikolajbrzezinski
Copy link
Contributor

@mikolajbrzezinski mikolajbrzezinski commented Jan 31, 2024

This change has been tested on an ARM64 environment and it worked correctly.

@mikolajbrzezinski mikolajbrzezinski changed the title ACS-6450 remove hardcoded ARM64 libreoffice download link ACS-6450 dynamically determine ARM64 libreoffice download link Feb 1, 2024
@dsibilio dsibilio requested a review from gionn February 1, 2024 09:29
@mikolajbrzezinski mikolajbrzezinski changed the title ACS-6450 dynamically determine ARM64 libreoffice download link ACS-6450 dynamically determine ARM64 LibreOffice download link Feb 1, 2024
Copy link
Contributor

@dsibilio dsibilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not usually a fan of Docker builds that fetch stuff remotely and could fail due to changes in an external repository.

Even so, the version-fetching command seems to be specific enough that at least we're not changing the LibreOffice version per se (it's tagged to 6.4.7.2) but only the number after the dash (the package release number, currently -15) which I believe is used in case of very minor re-releases that only involve security patches. This frees us from the burden of manually intervening when the repository is updated ever so slightly.

I'm still wondering how much can change within the repository, it's now been ~7 months since we added support for ARM64 in this repo and the package release number only changed twice. No real version number changed. So I'm hopeful that this automation combined with the stability of the RL repository would save us from further trouble in the future until we decide to move to a newer version of Rocky Linux & LibreOffice altogether.

@dsibilio dsibilio changed the title ACS-6450 dynamically determine ARM64 LibreOffice download link ACS-6450 Dynamically determine ARM64 LibreOffice download link Feb 1, 2024
engines/aio/Dockerfile Outdated Show resolved Hide resolved
@mikolajbrzezinski mikolajbrzezinski merged commit aae8bb8 into master Feb 13, 2024
21 checks passed
@mikolajbrzezinski mikolajbrzezinski deleted the fix/ACS-6450_remove_hardcoded_arm64_libreoffice branch February 13, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants