-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACS-6450 Dynamically determine ARM64 LibreOffice download link #923
ACS-6450 Dynamically determine ARM64 LibreOffice download link #923
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not usually a fan of Docker builds that fetch stuff remotely and could fail due to changes in an external repository.
Even so, the version-fetching command seems to be specific enough that at least we're not changing the LibreOffice version per se (it's tagged to 6.4.7.2
) but only the number after the dash (the package release number, currently -15
) which I believe is used in case of very minor re-releases that only involve security patches. This frees us from the burden of manually intervening when the repository is updated ever so slightly.
I'm still wondering how much can change within the repository, it's now been ~7 months since we added support for ARM64 in this repo and the package release number only changed twice. No real version number changed. So I'm hopeful that this automation combined with the stability of the RL repository would save us from further trouble in the future until we decide to move to a newer version of Rocky Linux & LibreOffice altogether.
This change has been tested on an ARM64 environment and it worked correctly.