ACS-6151 - Create ATS liveness/readiness probes tests #892
Conversation
engines/base/pom.xml
Outdated
| <dependency> | ||
| <groupId>org.testcontainers</groupId> | ||
| <artifactId>junit-jupiter</artifactId> | ||
| <version>1.19.1</version> |
There was a problem hiding this comment.
<scope>test</scope> seems to be missing here
There was a problem hiding this comment.
Added missing scope
There was a problem hiding this comment.
Update: after adding the scope all tests has failed: TestEngine with ID 'junit-jupiter' failed to discover tests
|
|
||
| int max_transforms = 11; | ||
| for (int i = 0; i<max_transforms; i++) { | ||
| sendTransformRequest(url, testData.sourceMimetype, testData.targetMimetype, testData.filename); |
There was a problem hiding this comment.
Would be good to add an assertion that probe is successful before sending transformation request
There was a problem hiding this comment.
Added an assertion before sending each request
| env.start(); | ||
| var url = "http://localhost:" + env.getFirstMappedPort(); | ||
|
|
||
| int max_transforms = 11; |
There was a problem hiding this comment.
Make max_transforms a class level constant. Set it to 10 and use it here and also in the createEnv method.
There was a problem hiding this comment.
Moved this value to a constant and used in both places
There was a problem hiding this comment.
Can this file be moved to the concrete TEngine using it?
There was a problem hiding this comment.
Instead of moving this file I used existing quick.jpg and quick.pdf files for ImageMagick and PdfRenderer tests. Removed my test files.
There was a problem hiding this comment.
Can this file be moved to the concrete TEngine using it?
goleksyalfresco
deleted the
acs-6151-create-ats-liveness-readiness-probes-tests
branch
No description provided.