-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNT-23960] Added new options (pdfFont, pdfFontSize) to textToPdf transformer #885
Merged
tiagosalvado10
merged 27 commits into
master
from
fix/MNT-23960_add-notosans-and-font-options
Feb 6, 2024
Merged
[MNT-23960] Added new options (pdfFont, pdfFontSize) to textToPdf transformer #885
tiagosalvado10
merged 27 commits into
master
from
fix/MNT-23960_add-notosans-and-font-options
Feb 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o textToPdf transformer
…ard map, mapped fonts or file system
tiagosalvado10
changed the title
[MNT-23960] Added options (pdfFont, pdfFontSize) and NotoSans fonts to textToPdf transformer
[MNT-23960] Added new options (pdfFont, pdfFontSize) to textToPdf transformer
Jan 29, 2024
….pdfbox.defaultFont' configuration to core-aio and misc T-Engines
tiagosalvado10
force-pushed
the
fix/MNT-23960_add-notosans-and-font-options
branch
from
February 5, 2024 13:19
4f6b7f3
to
1fa2ed0
Compare
jottley
approved these changes
Feb 5, 2024
...misc/src/main/java/org/alfresco/transform/misc/transformers/TextToPdfContentTransformer.java
Outdated
Show resolved
Hide resolved
...misc/src/main/java/org/alfresco/transform/misc/transformers/TextToPdfContentTransformer.java
Show resolved
Hide resolved
...misc/src/main/java/org/alfresco/transform/misc/transformers/TextToPdfContentTransformer.java
Outdated
Show resolved
Hide resolved
...misc/src/main/java/org/alfresco/transform/misc/transformers/TextToPdfContentTransformer.java
Outdated
Show resolved
Hide resolved
...misc/src/main/java/org/alfresco/transform/misc/transformers/TextToPdfContentTransformer.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/alfresco/transform/misc/transformers/TextToPdfContentTransformerTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/alfresco/transform/misc/transformers/TextToPdfContentTransformerTest.java
Outdated
Show resolved
Hide resolved
dsibilio
requested changes
Feb 6, 2024
...misc/src/main/java/org/alfresco/transform/misc/transformers/TextToPdfContentTransformer.java
Outdated
Show resolved
Hide resolved
...misc/src/main/java/org/alfresco/transform/misc/transformers/TextToPdfContentTransformer.java
Outdated
Show resolved
Hide resolved
...misc/src/main/java/org/alfresco/transform/misc/transformers/TextToPdfContentTransformer.java
Outdated
Show resolved
Hide resolved
...misc/src/main/java/org/alfresco/transform/misc/transformers/TextToPdfContentTransformer.java
Show resolved
Hide resolved
...misc/src/main/java/org/alfresco/transform/misc/transformers/TextToPdfContentTransformer.java
Show resolved
Hide resolved
...misc/src/main/java/org/alfresco/transform/misc/transformers/TextToPdfContentTransformer.java
Outdated
Show resolved
Hide resolved
...misc/src/main/java/org/alfresco/transform/misc/transformers/TextToPdfContentTransformer.java
Outdated
Show resolved
Hide resolved
…s not used anymore
…ined a default value at code level
...misc/src/main/java/org/alfresco/transform/misc/transformers/TextToPdfContentTransformer.java
Outdated
Show resolved
Hide resolved
...misc/src/main/java/org/alfresco/transform/misc/transformers/TextToPdfContentTransformer.java
Outdated
Show resolved
Hide resolved
…ods. Added assertion to testUTF8WithBOM test.
Co-authored-by: Tom Page <[email protected]>
…com:Alfresco/alfresco-transform-core into fix/MNT-23960_add-notosans-and-font-options
...misc/src/main/java/org/alfresco/transform/misc/transformers/TextToPdfContentTransformer.java
Outdated
Show resolved
Hide resolved
...misc/src/main/java/org/alfresco/transform/misc/transformers/TextToPdfContentTransformer.java
Outdated
Show resolved
Hide resolved
...misc/src/main/java/org/alfresco/transform/misc/transformers/TextToPdfContentTransformer.java
Outdated
Show resolved
Hide resolved
...misc/src/main/java/org/alfresco/transform/misc/transformers/TextToPdfContentTransformer.java
Outdated
Show resolved
Hide resolved
tpage-alfresco
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks Tiago.
tiagosalvado10
deleted the
fix/MNT-23960_add-notosans-and-font-options
branch
February 6, 2024 16:26
tiagosalvado10
added a commit
that referenced
this pull request
Feb 16, 2024
…nsformer (#885) * [MNT-23960] Added options (pdfFont, pdfFontSize) and NotoSans fonts to textToPdf transformer * [MNT-23960] Added 'MISC_PDFBOX_DEFAULT_FONT' and 'transform.core.misc.pdfbox.defaultFont' configuration to core-aio and misc T-Engines * [MNT-23960] Added NotoSans fonts to core-aio and misc T-Engine images * [MNT-23960] Improved logging: added messages, using placeholders * [MNT-23960] Added DEFAULT_FONT constant (NotoSans-Regular) * [MNT-23960] Splitted getFont(PDDocument, String) code into 3 methods. Added Javadoc. * [MNT-23960] Return TransformCheckResult on transformTextAndCheck methods. Added assertion to testUTF8WithBOM test. (cherry picked from commit b9bcc3c)
tiagosalvado10
added a commit
that referenced
this pull request
Feb 16, 2024
…nsformer (#885) (#929) * [MNT-23960] Added new options (pdfFont, pdfFontSize) to textToPdf transformer (#885) * [MNT-23960] Added options (pdfFont, pdfFontSize) and NotoSans fonts to textToPdf transformer * [MNT-23960] Added 'MISC_PDFBOX_DEFAULT_FONT' and 'transform.core.misc.pdfbox.defaultFont' configuration to core-aio and misc T-Engines * [MNT-23960] Added NotoSans fonts to core-aio and misc T-Engine images * [MNT-23960] Improved logging: added messages, using placeholders * [MNT-23960] Added DEFAULT_FONT constant (NotoSans-Regular) * [MNT-23960] Splitted getFont(PDDocument, String) code into 3 methods. Added Javadoc. * [MNT-23960] Return TransformCheckResult on transformTextAndCheck methods. Added assertion to testUTF8WithBOM test. (cherry picked from commit b9bcc3c) * [MNT-24238] Removed jakarta.annotation.PostConstruct import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.