ACS-6168: Add 5 retries when retrieving the temp directory to deal wi…

…th clashes when high load is applied immediatelly at startup
Alfresco · Oct 26, 2023 · ab70588 · ab70588
1 parent 19feada
commit ab70588
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 8 deletions.
diff --git a/...ated/alfresco-transformer-base/src/main/java/org/alfresco/transformer/fs/FileManager.java b/...ated/alfresco-transformer-base/src/main/java/org/alfresco/transformer/fs/FileManager.java
@@ -271,12 +271,16 @@ private static File getTempDir()
 
             final File systemTempDir = new File(systemTempDirPath);
             final File tempDir = new File(systemTempDir, dirName);
-            if (!tempDir.exists() && !tempDir.mkdirs() && !tempDir.exists())
-            {
-                throw new RuntimeException("Failed to create temp directory: " + tempDir);
+
+            int retrieveTempDirAttemptLimit = 5;
+            for (int i = 0; i < retrieveTempDirAttemptLimit; i++) {
+                if (tempDir.exists() || tempDir.mkdirs())
+                {
+                    return tempDir;
+                }
             }
 
-            return tempDir;
+            throw new RuntimeException("Failed to create temp directory: " + tempDir);
         }
     }
 }
diff --git a/engines/base/src/main/java/org/alfresco/transform/base/fs/FileManager.java b/engines/base/src/main/java/org/alfresco/transform/base/fs/FileManager.java
@@ -230,12 +230,16 @@ private static File getTempDir()
 
             final File systemTempDir = new File(systemTempDirPath);
             final File tempDir = new File(systemTempDir, dirName);
-            if (!tempDir.exists() && !tempDir.mkdirs())
-            {
-                throw new RuntimeException("Failed to create temp directory: " + tempDir);
+
+            int retrieveTempDirAttemptLimit = 5;
+            for (int i = 0; i < retrieveTempDirAttemptLimit; i++) {
+                if (tempDir.exists() || tempDir.mkdirs())
+                {
+                    return tempDir;
+                }
             }
 
-            return tempDir;
+            throw new RuntimeException("Failed to create temp directory: " + tempDir);
         }
     }
 }