Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-7419] Fix notifications #9503

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

tomson7777
Copy link
Contributor

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

@CLAassistant
Copy link

CLAassistant commented Apr 3, 2024

CLA assistant check
All committers have signed the CLA.

@tomson7777 tomson7777 changed the base branch from develop to dev-valbano-migration-ng15 April 3, 2024 10:17
@tomson7777 tomson7777 changed the base branch from dev-valbano-migration-ng15 to dev-valbano-ng15-start April 3, 2024 10:17
@nikita-web-ua
Copy link
Contributor

Maybe better to align 'notifications' text with button

Screenshot 2024-04-03 at 12 27 02

@tomson7777
Copy link
Contributor Author

Maybe better to align 'notifications' text with button

Screenshot 2024-04-03 at 12 27 02

good catch, fixed

@tomson7777 tomson7777 changed the title [ACS-7419] Dix notifications [ACS-7419] Fix notifications Apr 4, 2024
@tomson7777 tomson7777 merged commit 747c101 into dev-valbano-ng15-start Apr 4, 2024
1 check was pending
@tomson7777 tomson7777 deleted the ACS-7419-fix-notifications branch April 4, 2024 14:00
Copy link

sonarqubecloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@VitoAlbano VitoAlbano restored the ACS-7419-fix-notifications branch April 11, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants