Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-6565] ADW - Document List View Header - UX Bugs #9269

Merged

Conversation

jacekpluta
Copy link
Contributor

@jacekpluta jacekpluta commented Jan 22, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ACS-6565

What is the new behaviour?
Fixes according to the issue in JIRA.
image

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@CLAassistant
Copy link

CLAassistant commented Jan 22, 2024

CLA assistant check
All committers have signed the CLA.

@jacekpluta jacekpluta force-pushed the bugfix/ACS-5133-Document-List-View-Header-UX-Bugs branch from 49bb25f to 27170f0 Compare January 22, 2024 10:18
Copy link
Contributor

@MichalKinas MichalKinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM :D please also get in touch with someone from HxP to make sure we're not introducing breaking changes on their side, as datatable is a shared component

@jacekpluta jacekpluta force-pushed the bugfix/ACS-5133-Document-List-View-Header-UX-Bugs branch from 27170f0 to 13cbcdc Compare January 26, 2024 10:05
@jacekpluta jacekpluta force-pushed the bugfix/ACS-5133-Document-List-View-Header-UX-Bugs branch from 13cbcdc to 833c7d8 Compare January 26, 2024 10:27
@jacekpluta jacekpluta force-pushed the bugfix/ACS-5133-Document-List-View-Header-UX-Bugs branch from 833c7d8 to fb4c987 Compare January 26, 2024 15:03
Copy link
Contributor

@eromano eromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @popovicsandras can you give it a look as well?

@jacekpluta jacekpluta force-pushed the bugfix/ACS-5133-Document-List-View-Header-UX-Bugs branch 4 times, most recently from 29b8fef to d1cb3f2 Compare January 29, 2024 13:04
Copy link
Contributor

@DenysVuika DenysVuika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but please review the comments

@jacekpluta jacekpluta force-pushed the bugfix/ACS-5133-Document-List-View-Header-UX-Bugs branch from d1cb3f2 to 58a4753 Compare January 30, 2024 22:30
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jacekpluta jacekpluta merged commit 81c17da into develop Jan 31, 2024
33 checks passed
@jacekpluta jacekpluta deleted the bugfix/ACS-5133-Document-List-View-Header-UX-Bugs branch January 31, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants