-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACS-6565] ADW - Document List View Header - UX Bugs #9269
[ACS-6565] ADW - Document List View Header - UX Bugs #9269
Conversation
49bb25f
to
27170f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest LGTM :D please also get in touch with someone from HxP to make sure we're not introducing breaking changes on their side, as datatable is a shared component
...ces/src/lib/search/components/search-filter-container/search-filter-container.component.scss
Outdated
Show resolved
Hide resolved
27170f0
to
13cbcdc
Compare
13cbcdc
to
833c7d8
Compare
833c7d8
to
fb4c987
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @popovicsandras can you give it a look as well?
29b8fef
to
d1cb3f2
Compare
lib/core/src/lib/datatable/components/datatable/datatable.component.html
Outdated
Show resolved
Hide resolved
lib/core/src/lib/datatable/components/datatable/datatable.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, but please review the comments
d1cb3f2
to
58a4753
Compare
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ACS-6565
What is the new behaviour?
Fixes according to the issue in JIRA.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: