[MNT-23433] configure position for close button on Viewer #9143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnukritiGL
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
rbahirsheth
reviewed
Dec 7, 2023
rbahirsheth
approved these changes
Dec 7, 2023
MichalKinas
requested changes
Dec 8, 2023
lib/content-services/src/lib/viewer/components/alfresco-viewer.component.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/viewer/components/alfresco-viewer.component.ts
Outdated
Show resolved
Hide resolved
AnukritiGL
force-pushed
the
MNT-23433-preview-buttons-positions-configuration
branch
2 times, most recently
from
3be17a8 to
5c55a26
Compare
MichalKinas
reviewed
Dec 12, 2023
lib/content-services/src/lib/viewer/components/alfresco-viewer.component.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/viewer/components/alfresco-viewer.component.ts
Outdated
Show resolved
Hide resolved
| @@ -61,7 +61,8 @@ See the [Custom layout](#custom-layout) section for full details of all availabl | |||
| | Name | Type | Default value | Description | | |||
| | ---- | ---- | ------------- | ----------- | | |||
| | allowFullScreen | `boolean` | true | Toggles the 'Full Screen' feature. | | |||
| | allowGoBack | `boolean` | true | Allows `back` navigation | | |||
| | allowGoBack | `boolean` | true | Allows `back` navigation. | | |||
| | closeButtonPosition | `string` | `left` | Set close button position right/left. | | |||
There was a problem hiding this comment.
instead of string should be CloseButtonPosition type
AnukritiGL
force-pushed
the
MNT-23433-preview-buttons-positions-configuration
branch
from
f01ea91 to
151cc4a
Compare
swapnil-verma-gl
approved these changes
Dec 28, 2023
AnukritiGL
force-pushed
the
MNT-23433-preview-buttons-positions-configuration
branch
from
8c79fc8 to
3daf9bc
Compare
MichalKinas
reviewed
Jan 2, 2024
| | allowGoBack | `boolean` | true | Allows `back` navigation | | ||
| | allowGoBack | `boolean` | true | Allows `back` navigation. | | ||
| | closeButtonPosition | `CloseButtonPosition` | `left` | Set close button position right/left. | | ||
| | hideInfoButton | `boolean` | `false` | Toggles Info button. | |
There was a problem hiding this comment.
Suggested change
| | hideInfoButton | `boolean` | `false` | Toggles Info button. | | |
| | hideInfoButton | `boolean` | false | Toggles Info button. | |
| fixture.detectChanges(); | ||
| fixture.whenStable().then(() => { | ||
| fixture.detectChanges(); | ||
| expect(element.querySelector('[data-automation-id="adf-toolbar-back"]')).toBeDefined(); | ||
| expect(element.querySelector('[data-automation-id="adf-toolbar-back"]')).not.toBeNull(); | ||
| expect(element.querySelector('[data-automation-id="adf-toolbar-left-back"]')).toBeDefined(); |
There was a problem hiding this comment.
One of those statements is obsolete, first you check if the element is defined and then if it's not a null
There was a problem hiding this comment.
Removed obsolete statements
| @@ -23,9 +23,9 @@ | |||
| </button> | |||
| </ng-container> | |||
|
|
|||
| <button *ngIf="allowGoBack" | |||
| <button *ngIf="allowGoBack && closeButtonPosition === 'left'" | |||
There was a problem hiding this comment.
Should be CloseButtonPosition.Left instead of left
| @@ -120,6 +120,19 @@ | |||
| </mat-menu> | |||
| </ng-container> | |||
|
|
|||
| <ng-container *ngIf="allowGoBack && closeButtonPosition === 'right'"> | |||
| fixture.detectChanges(); | ||
| fixture.whenStable().then(() => { | ||
| fixture.detectChanges(); | ||
| expect(element.querySelector('[data-automation-id="adf-toolbar-back"]')).toBeDefined(); | ||
| expect(element.querySelector('[data-automation-id="adf-toolbar-back"]')).not.toBeNull(); | ||
| expect(element.querySelector('[data-automation-id="adf-toolbar-left-back"]')).toBeDefined(); |
There was a problem hiding this comment.
Same here for obsolete check
There was a problem hiding this comment.
Removed obsolete statements
MichalKinas
approved these changes
Jan 2, 2024
|
AnukritiGL
deleted the
MNT-23433-preview-buttons-positions-configuration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
The button to close the preview is located on the left side while the other control buttons are on the right.
What is the new behaviour?
The button to close the preview is now configurable, customer can set the position of close button either left or right.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
https://alfresco.atlassian.net/browse/MNT-23433
Dependent PR link : Alfresco/alfresco-content-app#3535