[AAE-18450] fixed form value not updating instantly on radio change #9141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojd0
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
ehsan-2019
reviewed
Dec 4, 2023
...vices-cloud/src/lib/form/components/widgets/radio-buttons/radio-buttons-cloud.widget.spec.ts
Show resolved
Hide resolved
ehsan-2019
reviewed
Dec 4, 2023
...vices-cloud/src/lib/form/components/widgets/radio-buttons/radio-buttons-cloud.widget.spec.ts
Show resolved
Hide resolved
ehsan-2019
reviewed
Dec 4, 2023
| @@ -149,8 +151,8 @@ describe('RadioButtonsCloudWidgetComponent', () => { | |||
| }); | |||
|
|
|||
| fixture.detectChanges(); | |||
| const selectedOption = element.querySelector<HTMLElement>('[class*="mat-radio-checked"]'); | |||
| expect(selectedOption.innerText).toBe('opt-name-2'); | |||
| const selectedOption = await loader.getHarness(MatRadioButtonHarness.with({ checked: true })); | |||
There was a problem hiding this comment.
you can add label directly to the filters
wojd0
force-pushed
the
dev-wduda-AAE-18450
branch
from
9c0fc23 to
2a280ed
Compare
ehsan-2019
approved these changes
Dec 4, 2023
ehsan-2019
reviewed
Dec 4, 2023
| fixture.detectChanges(); | ||
| const selectedOption = element.querySelector<HTMLElement>('[class*="mat-radio-checked"]'); | ||
| expect(selectedOption.innerText).toBe('opt-name-1'); | ||
| const selectedOption = await loader.getHarness(MatRadioButtonHarness.with({ checked: true })); |
There was a problem hiding this comment.
same as below, label can be added to the filter
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/AAE-18450
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: