[ADF-5570][ADF-5571]Removed important property from 'toolbar.component.scss' and 'pagination.component.scss' in ADF

[Yasa-Nataliya]

Please check if the PR fulfills these requirements

• The commit message follows our guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation
• Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
use !important for styles should be disallowed.

What is the new behaviour?
Removed 'important' property from ''toolbar.component.scss' and 'pagination.component.scss''. After removing the important property I tested ACA, ADF, ADW, and admin-cc, and it’s working as expected.

Does this PR introduce a breaking change? (check one with "x")

• Yes
• No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://alfresco.atlassian.net/browse/ADF-5570,
https://alfresco.atlassian.net/browse/ADF-5571.

[AleksanderSklorz]

Hi @Yasa-Nataliya. I will approve that PR but before that could you please do one thing? I see this original task: https://alfresco.atlassian.net/browse/ADF-5548 is splitted into multiple subtasks for removing important.

But there is missing one subtask to add this rule to stylelint:

So when we remove all importants for styles then we need to add "declaration-no-important": true rule to .stylelintrc.json file like for other projects for example like in ACA.

Could you please create this subtask in that mentioned original jira and paste here in that PR ID for this jira?

[Yasa-Nataliya]

Hi @Yasa-Nataliya. I will approve that PR but before that could you please do one thing? I see this original task: https://alfresco.atlassian.net/browse/ADF-5548 is splitted into multiple subtasks for removing important.

But there is missing one subtask to add this rule to stylelint:

So when we remove all importants for styles then we need to add "declaration-no-important": true rule to .stylelintrc.json file like for other projects for example like in ACA.

Could you please create this subtask in that mentioned original jira and paste here in that PR ID for this jira?

Hi @AleksanderSklorz,
We have created a Jira ticket for the "declaration-no-important" rule:https://alfresco.atlassian.net/browse/ADF-5575.
Please check it.
Thanks!

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication