Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRODENG-211] improved ADF CLI compilation #9105

Merged
merged 5 commits into from
Nov 22, 2023
Merged

[PRODENG-211] improved ADF CLI compilation #9105

merged 5 commits into from
Nov 22, 2023

Conversation

DenysVuika
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

  • remove the need for extra "npm install" for CLI
  • use mapped JS-API and other libs when building CLI
  • bug fixes for CLI

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://alfresco.atlassian.net/browse/PRODENG-211

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.5% 1.5% Duplication

@DenysVuika DenysVuika merged commit 3309ea6 into develop Nov 22, 2023
33 checks passed
@DenysVuika DenysVuika deleted the fix-cli-publish branch November 22, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleksanderSklorz AleksanderSklorz AleksanderSklorz approved these changes

@MichalKinas MichalKinas MichalKinas approved these changes

@eromano eromano Awaiting requested review from eromano eromano is a code owner

@popovicsandras popovicsandras Awaiting requested review from popovicsandras popovicsandras is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DenysVuika @MichalKinas @AleksanderSklorz