Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AAE-18105] Fix release workflow: release-npm step doesn't publish al… #9091

Merged
merged 1 commit into from
Nov 15, 2023
Merged

[AAE-18105] Fix release workflow: release-npm step doesn't publish al… #9091

merged 1 commit into from
Nov 15, 2023

Conversation

alep85
Copy link
Contributor

@alep85 alep85 commented Nov 15, 2023

…l the packages

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/AAE-18105

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ehsan-2019
Copy link
Contributor

LGTM!

@alep85 alep85 merged commit 17323b0 into develop Nov 15, 2023
35 checks passed
@alep85 alep85 deleted the dev-alepore-AAE-18105 branch November 15, 2023 15:56
alep85 added a commit that referenced this pull request Nov 15, 2023
@alep85
Revert "[AAE-18105] Fix release workflow: release-npm step doesn't pu…
75a09cc 
…blish all the packages (#9091)"

This reverts commit 17323b0.
@alep85 alep85 mentioned this pull request Nov 15, 2023
Merged
mauriziovitale pushed a commit that referenced this pull request Nov 15, 2023
@alep85
Revert "[AAE-18105] Fix release workflow: release-npm step doesn't pu…
22d3179 
…blish al…" (#9092)

* Revert "[AAE-18105] Fix release workflow: release-npm step doesn't publish all the  packages (#9091)"

This reverts commit 17323b0.

* Fix release workflow: publish always all the libs until we don't handle partial release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsan-2019 ehsan-2019 ehsan-2019 approved these changes

@eromano eromano Awaiting requested review from eromano eromano is a code owner

@popovicsandras popovicsandras Awaiting requested review from popovicsandras popovicsandras is a code owner

@DenysVuika DenysVuika Awaiting requested review from DenysVuika DenysVuika is a code owner

@mauriziovitale mauriziovitale Awaiting requested review from mauriziovitale

@andrea-ligios andrea-ligios Awaiting requested review from andrea-ligios

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alep85 @ehsan-2019